Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: ppapi/thunk/BUILD.gn

Issue 1061953002: Work on Windows GN component build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/shared_impl/BUILD.gn ('k') | ui/gl/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/thunk/BUILD.gn
diff --git a/ppapi/thunk/BUILD.gn b/ppapi/thunk/BUILD.gn
index 5b326e4495b96f3ba6c9a16d312bb082d3ae0d65..18096a4fbda303ae6b49c308590020e01617f4c3 100644
--- a/ppapi/thunk/BUILD.gn
+++ b/ppapi/thunk/BUILD.gn
@@ -3,6 +3,12 @@
# found in the LICENSE file.
source_set("thunk") {
+ # In GYP this is the same target as shared_impl. In GN these are split apart
+ # for clarity but to get component builds correct, targets must only depend
+ # on these via the shared_impl component.
+ # TODO(brettw) separate these when GYP compat is no longer required.
+ visibility = [ "//ppapi/shared_impl" ]
+
sources = [
"enter.cc",
"enter.h",
@@ -189,5 +195,11 @@ source_set("thunk") {
]
}
- defines = [ "PPAPI_THUNK_IMPLEMENTATION" ]
+ defines = [
+ # This target goes in the same library as shared_impl (in GYP they are the
+ # same).
+ "PPAPI_SHARED_IMPLEMENTATION",
+
+ "PPAPI_THUNK_IMPLEMENTATION",
+ ]
}
« no previous file with comments | « ppapi/shared_impl/BUILD.gn ('k') | ui/gl/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698