android: Merge CreateOffscreenContext and CreateContext into one function.

android: Merge CreateOffscreenContext and CreateContext into one function.

These refactor these two functions into a single one to ease the
transition of https://codereview.chromium.org/920443003.

Tested on Android (with Nexus 5 device) with the following command lines:

$ ./build/gyp_chromium -DOS=android -Goutput_dir=out_android
$ ninja -C out_android/Debug content_unittests content_unittests_apk
$ export CHROMIUM_OUT_DIR=out_android
$ build/android/test_runner.py gtest -s content_unittests --debug -vvv

ContentShell tests:
$ ninja -C out_android/Debug content_shell_apk
$ ninja -C out_android/Debug content_shell_test_apk
$ build/android/adb_install_apk.py --apk=ContentShell.apk --debug
$ build/android/test_runner.py instrumentation --test-apk=ContentShellTest --isolate-file-path content/content_shell_test_apk.isolate --debug -vv

AndroidWebView tests:
$ ninja -C out_android/Debug android_webview_apk
$ ninja -C out_android/Debug android_webview_test_apk
$ build/android/adb_install_apk.py --apk=AndroidWebView.apk --debug
$ build/android/test_runner.py instrumentation --test-apk=AndroidWebViewTest --test_data webview:android_webview/test/data/device_files --debug -vvv

BUG=338338
TEST=see above
R=boliu@chromium.org

Committed: https://crrev.com/c0a93f375a87b8a7685a19bba712f20ab22f168c
Cr-Commit-Position: refs/heads/master@{#324033}

[tfarina, 2015-04-04 02:33:28]

This is more manageable to me. Please, check if I got all the parameter values
right.

PTAL!

[boliu, 2015-04-07 02:23:26]

sorry for the delay

https://codereview.chromium.org/1061763002/diff/20001/content/browser/android...
File content/browser/android/in_process/synchronous_compositor_factory_impl.cc
(right):

https://codereview.chromium.org/1061763002/diff/20001/content/browser/android...
content/browser/android/in_process/synchronous_compositor_factory_impl.cc:61:
is_offscreen ? attributes.shareResources : share_resources,
Can just make this attributes.shareResources? Anything that had
attributes.shareResources != share_resources should be fixed.

[tfarina, 2015-04-07 04:01:43]

https://codereview.chromium.org/1061763002/diff/20001/content/browser/android...
File content/browser/android/in_process/synchronous_compositor_factory_impl.cc
(right):

https://codereview.chromium.org/1061763002/diff/20001/content/browser/android...
content/browser/android/in_process/synchronous_compositor_factory_impl.cc:61:
is_offscreen ? attributes.shareResources : share_resources,
On 2015/04/07 02:23:26, boliu wrote:
> Can just make this attributes.shareResources? Anything that had
> attributes.shareResources != share_resources should be fixed.

Done.

[boliu, 2015-04-07 04:08:23]

lgtm

[tfarina, 2015-04-07 12:11:33]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-04-07 12:11:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1061763002/40001

[commit-bot: I haz the power, 2015-04-07 12:15:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-07 12:16:08]

Patchset 3 (id:??) landed as
https://crrev.com/c0a93f375a87b8a7685a19bba712f20ab22f168c
Cr-Commit-Position: refs/heads/master@{#324033}