Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1061603002: Code's more readable when SkPMFloat is an Sk4f. (Closed)

Created:
5 years, 8 months ago by mtklein_C
Modified:
5 years, 8 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Code's more readable when SkPMFloat is an Sk4f. #floats BUG=skia: BUG=skia:3592 Committed: https://skia.googlesource.com/skia/+/6b5dab889579f1cc9e1b5278f4ecdc4c63fe78c9 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot Committed: https://skia.googlesource.com/skia/+/7792dbf7ea089b3bcb81792a3ecda8a6f8b421e7

Patch Set 1 #

Patch Set 2 : missed one #

Patch Set 3 : ; #

Patch Set 4 : fix neon #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -52 lines) Patch
M src/core/SkPMFloat.h View 3 chunks +9 lines, -12 lines 0 comments Download
M src/core/SkXfermode.cpp View 6 chunks +6 lines, -18 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/opts/SkNx_neon.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/opts/SkNx_sse.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/opts/SkPMFloat_SSE2.h View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M src/opts/SkPMFloat_SSSE3.h View 3 chunks +7 lines, -7 lines 0 comments Download
M src/opts/SkPMFloat_neon.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
mtklein_C
5 years, 8 months ago (2015-04-03 19:02:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061603002/1
5 years, 8 months ago (2015-04-03 19:02:58 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/149) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
5 years, 8 months ago (2015-04-03 19:04:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061603002/20001
5 years, 8 months ago (2015-04-03 19:14:46 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/152) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
5 years, 8 months ago (2015-04-03 19:15:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061603002/40001
5 years, 8 months ago (2015-04-03 19:16:55 UTC) #12
reed1
lgtm
5 years, 8 months ago (2015-04-03 19:21:13 UTC) #13
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-03 19:22:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061603002/40001
5 years, 8 months ago (2015-04-03 19:44:53 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/6b5dab889579f1cc9e1b5278f4ecdc4c63fe78c9
5 years, 8 months ago (2015-04-03 19:45:08 UTC) #18
mtklein
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1056143004/ by mtklein@google.com. ...
5 years, 8 months ago (2015-04-03 19:47:27 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061603002/60001
5 years, 8 months ago (2015-04-03 19:55:03 UTC) #22
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:08:31 UTC) #23
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/7792dbf7ea089b3bcb81792a3ecda8a6f8b421e7

Powered by Google App Engine
This is Rietveld 408576698