Issue 1061503008: [chrome/browser/local_discovery] favor DCHECK_CURRENTLY_ON for better logs

Issue 1061503008: [chrome/browser/local_discovery] favor DCHECK_CURRENTLY_ON for better logs (Closed)

Created:
5 years, 8 months ago by anujsharma

Modified:
5 years, 7 months ago

Reviewers:
Vitaly Buka (NO REVIEWS)

CC:
chromium-reviews, Mostyn Bramley-Moore

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/extensions BUG=466848 Committed: https://crrev.com/99290e7558260cfa01c3d9f8c9a0256aa342d7b3 Cr-Commit-Position: refs/heads/master@{#327444}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+82 lines, -82 lines)			Patch
M	chrome/browser/local_discovery/privet_traffic_detector.cc	View	5 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/local_discovery/pwg_raster_converter.cc	View	7 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/local_discovery/service_discovery_client_mdns.cc	View	9 chunks	+13 lines, -13 lines	0 comments	Download
M	chrome/browser/local_discovery/service_discovery_client_utility.cc	View	5 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/local_discovery/service_discovery_host_client.cc	View	19 chunks	+25 lines, -25 lines	0 comments	Download
M	chrome/browser/local_discovery/service_discovery_shared_client.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/local_discovery/wifi/wifi_manager_nonchromeos.cc	View	14 chunks	+16 lines, -16 lines	0 comments	Download

Total messages: 12 (4 generated)

anujsharma

@Vitaly Could you please give a thumbs up for this CL. Thanks!!

5 years, 7 months ago (2015-04-28 05:24:05 UTC) #3

anujsharma

On 2015/04/28 20:18:22, Vitaly Buka wrote: > lgtm Thanks vitaly buka for lgtm.

5 years, 7 months ago (2015-04-29 03:01:05 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061503008/1

5 years, 7 months ago (2015-04-29 03:03:05 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061503008/1

5 years, 7 months ago (2015-04-29 06:35:44 UTC) #10

commit-bot: I haz the power

5 years, 7 months ago (2015-04-29 07:11:43 UTC) #12

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/99290e7558260cfa01c3d9f8c9a0256aa342d7b3
Cr-Commit-Position: refs/heads/master@{#327444}