chrome/browser/local_discovery/service_discovery_shared_client.cc - Issue 1061503008: [chrome/browser/local_discovery] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/local_discovery/service_discovery_shared_client.cc

Issue 1061503008: [chrome/browser/local_discovery] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/local_discovery/service_discovery_host_client.cc ('k') | chrome/browser/local_discovery/wifi/wifi_manager_nonchromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/local_discovery/service_discovery_shared_client.cc

diff --git a/chrome/browser/local_discovery/service_discovery_shared_client.cc b/chrome/browser/local_discovery/service_discovery_shared_client.cc

index 3d6e89a8b0c668e6c7e08a6e2da0ac62dab5acf6..121de207b5af4c2fd3854fa4680585191d4a5a19 100644

--- a/chrome/browser/local_discovery/service_discovery_shared_client.cc

+++ b/chrome/browser/local_discovery/service_discovery_shared_client.cc

@@ -75,7 +75,7 @@ ServiceDiscoverySharedClient::~ServiceDiscoverySharedClient() {

scoped_refptr<ServiceDiscoverySharedClient>

ServiceDiscoverySharedClient::GetInstance() {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

if (g_service_discovery_client)

return g_service_discovery_client;

@@ -104,7 +104,7 @@ void ServiceDiscoverySharedClient::GetInstanceWithoutAlert(

return callback.Run(result);

#else // OS_WIN

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

// TODO(vitalybuka): Switch to |ServiceDiscoveryClientMdns| after we find what

// to do with firewall for user-level installs. crbug.com/366408

scoped_refptr<ServiceDiscoverySharedClient> result =

@@ -132,7 +132,7 @@ void ServiceDiscoverySharedClient::GetInstanceWithoutAlert(

scoped_refptr<ServiceDiscoverySharedClient>

ServiceDiscoverySharedClient::GetInstance() {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

NOTIMPLEMENTED();

return NULL;

}