Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1061503002: DevTools: use recordEnumeratedHistogram instead of recordActionTaken (Closed)

Created:
5 years, 8 months ago by lushnikov
Modified:
5 years, 8 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: use recordEnumeratedHistogram instead of recordActionTaken The patch migrates off recordActionTaken method in favor of recordEnumeratedHistogram. This makes it possible to supply bucket sizes from the javascript code. R=dgozman BUG=468026 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193409

Patch Set 1 #

Total comments: 8

Patch Set 2 : address comments #

Total comments: 4

Patch Set 3 : address comments #

Patch Set 4 : rebaseline #

Patch Set 5 : fix inspector/user-metrics.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -35 lines) Patch
M LayoutTests/inspector/user-metrics.html View 1 2 3 4 1 chunk +5 lines, -7 lines 0 comments Download
M Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js View 1 2 3 3 chunks +24 lines, -11 lines 0 comments Download
M Source/devtools/front_end/host/InspectorFrontendHost.js View 1 2 3 2 chunks +6 lines, -15 lines 0 comments Download
M Source/devtools/front_end/host/UserMetrics.js View 1 2 3 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
lushnikov
PTAL. Chromium-side patch should land first: https://codereview.chromium.org/1056073003
5 years, 8 months ago (2015-04-03 14:18:31 UTC) #1
dgozman
https://codereview.chromium.org/1061503002/diff/1/Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js File Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js (right): https://codereview.chromium.org/1061503002/diff/1/Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js#newcode184 Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js:184: * @override Should not be override. https://codereview.chromium.org/1061503002/diff/1/Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js#newcode187 Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js:187: recordActionTaken: ...
5 years, 8 months ago (2015-04-03 14:23:48 UTC) #2
lushnikov
https://codereview.chromium.org/1061503002/diff/1/Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js File Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js (right): https://codereview.chromium.org/1061503002/diff/1/Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js#newcode184 Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js:184: * @override On 2015/04/03 14:23:48, dgozman wrote: > Should ...
5 years, 8 months ago (2015-04-03 14:41:25 UTC) #3
dgozman
lgtm https://codereview.chromium.org/1061503002/diff/20001/Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js File Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js (right): https://codereview.chromium.org/1061503002/diff/20001/Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js#newcode444 Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js:444: * @param {number} actionCode Support for legacy front-ends ...
5 years, 8 months ago (2015-04-03 14:43:17 UTC) #4
lushnikov
https://codereview.chromium.org/1061503002/diff/20001/Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js File Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js (right): https://codereview.chromium.org/1061503002/diff/20001/Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js#newcode444 Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js:444: * @param {number} actionCode On 2015/04/03 14:43:17, dgozman wrote: ...
5 years, 8 months ago (2015-04-03 14:49:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061503002/60001
5 years, 8 months ago (2015-04-08 14:04:27 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/50966)
5 years, 8 months ago (2015-04-08 17:53:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061503002/80001
5 years, 8 months ago (2015-04-08 23:46:34 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 02:50:45 UTC) #14
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193409

Powered by Google App Engine
This is Rietveld 408576698