Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1951)

Unified Diff: Source/devtools/front_end/host/UserMetrics.js

Issue 1061503002: DevTools: use recordEnumeratedHistogram instead of recordActionTaken (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix inspector/user-metrics.html Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/host/InspectorFrontendHost.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/host/UserMetrics.js
diff --git a/Source/devtools/front_end/host/UserMetrics.js b/Source/devtools/front_end/host/UserMetrics.js
index 3c1215456fc1e93d66690ba2d6cc4ab68097f3d7..b0ab53e6fa4f106f0d9dfb65b419f52967a3bac8 100644
--- a/Source/devtools/front_end/host/UserMetrics.js
+++ b/Source/devtools/front_end/host/UserMetrics.js
@@ -86,9 +86,14 @@ WebInspector.UserMetrics.UserActionNames = {
};
WebInspector.UserMetrics.prototype = {
+ /**
+ * @param {string} panelName
+ */
panelShown: function(panelName)
{
- InspectorFrontendHost.recordPanelShown(WebInspector.UserMetrics._PanelCodes[panelName] || 0);
+ var code = WebInspector.UserMetrics._PanelCodes[panelName] || 0;
+ var size = Object.keys(WebInspector.UserMetrics._PanelCodes).length + 1;
+ InspectorFrontendHost.recordEnumeratedHistogram("DevTools.PanelShown", code, size);
}
}
@@ -103,7 +108,8 @@ WebInspector.UserMetrics._Recorder = function(actionCode)
WebInspector.UserMetrics._Recorder.prototype = {
record: function()
{
- InspectorFrontendHost.recordActionTaken(this._actionCode);
+ var size = Object.keys(WebInspector.UserMetrics._ActionCodes).length + 1;
+ InspectorFrontendHost.recordEnumeratedHistogram("DevTools.ActionTaken", this._actionCode, size);
}
}
« no previous file with comments | « Source/devtools/front_end/host/InspectorFrontendHost.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698