gyp_chromium: Escape " for gn files.

gyp_chromium: Escape " for gn files.

BUG=326024
TBR=brettw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238883

[Nico, 2013-12-05 03:50:25]

The gn documentation experience here wasn't amazing: I first looked through `gn
help` and a few subtopics but didn't find anything on quoting. Then I searched
for "gn escaping" on google and didn't find anything. I then trawled through
gn's source and found tokenizer.cc which has

bool Tokenizer::IsCurrentStringTerminator(char quote_char) const {
  DCHECK(!at_end());
  if (cur_char() != quote_char)
    return false;

  // Check for escaping. \" is not a string terminator, but \\" is. Count
  // the number of preceeding backslashes.
  int num_backslashes = 0;
  for (int i = static_cast<int>(cur_) - 1; i >= 0 && input_[i] == '\\'; i--)
    num_backslashes++;

  // Even backslashes mean that they were escaping each other and don't count
  // as escaping this quote.
  return (num_backslashes % 2) == 0;
}

from which I inferred that " is probably escaped with \. Nothing else in that
file tries to convert '\"' to just '"' in that file, so I'm not at all sure if
that is correct. But it seems to fix a gyp-time crash for some people, so it
seems better to check this in then not.

[Nico, 2013-12-05 03:51:52]

Committed patchset #1 manually as r238883.

[brettw, 2013-12-05 04:50:14]

LGTM, thanks!