gyp_chromium: Escape " for gn files.

build/gyp_chromium

 #!/usr/bin/env python
 
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This script is wrapper for Chromium that adds some support for how GYP
 # is invoked by Chromium beyond what can be done in the gclient hooks.
 
 import glob
@@ skipping 54 matching lines @@
 
 def FormatKeyForGN(key):
   """Returns the given GYP key reformatted for GN.
 
   GYP dictionary keys can be almost anything, but in GN they are identifiers
   and must follow the same rules. This reformats such keys to be valid GN
   identifiers."""
   return ''.join([c if c in string.ascii_letters else '_' for c in key])
 
 
+def EscapeStringForGN(s):
+  """Converts a string to a GN string literal."""
+  # Escape $ characters which have special meaning to GN.
+  return '"' + s.replace('$', '\\$').replace('"', '\\"') + '"'
+
+
 def GetVarsStringForGN(supplemental_files):
   vars_dict = {}
 
   for supplement in supplemental_files:
     with open(supplement, 'r') as f:
       try:
         file_data = eval(f.read(), {'__builtins__': None}, None)
       except SyntaxError, e:
         e.filename = os.path.abspath(supplement)
         raise
       variables = file_data.get('variables', [])
       for v in variables:
-        vars_dict[FormatKeyForGN(v)] = '"' + \
-            str(variables[v]).replace("$", "\\$") + '"'
+        vars_dict[FormatKeyForGN(v)] = EscapeStringForGN(str(variables[v]))
 
   env_string = os.environ.get('GYP_DEFINES', '')
   items = shlex.split(env_string)
   for item in items:
     tokens = item.split('=', 1)
     # Some GYP variables have hyphens, which we don't support.
     key = FormatKeyForGN(tokens[0])
     if len(tokens) == 2:
-      # Escape $ characters which have special meaning to GN.
-      vars_dict[key] = '"' + tokens[1].replace("$", "\\$") + '"'
+      vars_dict[key] = EscapeStringForGN(tokens[1])
     else:
       # No value supplied, treat it as a boolean and set it.
       vars_dict[key] = 'true'
 
   vars_string = ''
   for v in vars_dict:
     vars_string = vars_string + v + '=' + vars_dict[v] + ' '
   return vars_string.strip()  # Remove trailing space.
 
 
@@ skipping 169 matching lines @@
   # to enfore syntax checking.
   syntax_check = os.environ.get('CHROMIUM_GYP_SYNTAX_CHECK')
   if syntax_check and int(syntax_check):
     args.append('--check')
 
   print 'Updating projects from gyp files...'
   sys.stdout.flush()
 
   # Off we go...
   sys.exit(gyp.main(args))