Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Issue 1061233004: [Mac] Add "Supervised" and "Accounts for kids" labels in the fast user switcher (Closed)

Created:
5 years, 8 months ago by Marc Treib
Modified:
5 years, 8 months ago
Reviewers:
msw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Add "Supervised" and "Accounts for kids" labels in the fast user switcher This is the Mac part for https://crrev.com/1018003002 and https://crrev.com/1028603003 BUG=463463 Committed: https://crrev.com/673250ae542e850ddd9ff7c3c76c62bc6a66c500 Cr-Commit-Position: refs/heads/master@{#325210}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 1 chunk +11 lines, -1 line 2 comments Download

Messages

Total messages: 8 (2 generated)
Marc Treib
PTAL!
5 years, 8 months ago (2015-04-14 12:49:36 UTC) #2
msw
lgtm with an idea for later followup. https://codereview.chromium.org/1061233004/diff/1/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right): https://codereview.chromium.org/1061233004/diff/1/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm#newcode1807 chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:1807: if (item.legacy_supervised) ...
5 years, 8 months ago (2015-04-14 18:15:12 UTC) #3
Marc Treib
https://codereview.chromium.org/1061233004/diff/1/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right): https://codereview.chromium.org/1061233004/diff/1/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm#newcode1807 chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:1807: if (item.legacy_supervised) { On 2015/04/14 18:15:12, msw wrote: > ...
5 years, 8 months ago (2015-04-15 07:47:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061233004/1
5 years, 8 months ago (2015-04-15 07:47:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 08:32:39 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 08:33:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/673250ae542e850ddd9ff7c3c76c62bc6a66c500
Cr-Commit-Position: refs/heads/master@{#325210}

Powered by Google App Engine
This is Rietveld 408576698