sky/engine/core/css/parser/CSSPropertyParser.cpp - Issue 1061163002: Remove all uses of display:block and display:inline-block.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/css/parser/CSSPropertyParser.cpp

Issue 1061163002: Remove all uses of display:block and display:inline-block. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: update one more usage Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/css/parser/CSSPropertyParser.cpp

diff --git a/sky/engine/core/css/parser/CSSPropertyParser.cpp b/sky/engine/core/css/parser/CSSPropertyParser.cpp

index 4beb299fc4f4d3d7fd7d26e63f7ad8004dbafc91..2361012e06e81c1c1f8fcba83a1bfe5452d3bc9d 100644

--- a/sky/engine/core/css/parser/CSSPropertyParser.cpp

+++ b/sky/engine/core/css/parser/CSSPropertyParser.cpp

@@ -4257,6 +4257,7 @@ static bool isFlexBasisMiddleArg(double flexGrow, double flexShrink, double unse

return flexGrow != unsetValue && flexShrink == unsetValue && argSize == 3;

}

+// TODO(ojan): Make this have reasonable defaults.

bool CSSPropertyParser::parseFlex(CSSParserValueList* args)

{

if (!args || !args->size() || args->size() > 3)