Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 106103009: Move remaining KeyCode files to platform/ (Closed)

Created:
7 years ago by jbroman
Modified:
6 years, 12 months ago
Reviewers:
Dirk Pranke, eseidel
CC:
blink-reviews, pilgrim_google
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move remaining KeyCode files to platform/ This is a reland of r164107 (which was reverted due to an Android build error). https://codereview.chromium.org/111403004 There was a missing #include in KeyCodeConversionAndroid.cpp which prevented a function from being exported from the platform component. BUG=297477, 329743 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164363

Patch Set 1 #

Patch Set 2 : add missing include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -813 lines) Patch
M Source/core/core.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
D Source/core/platform/chromium/KeyCodeConversion.h View 1 chunk +0 lines, -40 lines 0 comments Download
D Source/core/platform/chromium/KeyCodeConversionAndroid.cpp View 1 chunk +0 lines, -329 lines 0 comments Download
D Source/core/platform/chromium/KeyCodeConversionGtk.cpp View 1 chunk +0 lines, -436 lines 0 comments Download
A + Source/platform/KeyCodeConversion.h View 1 chunk +3 lines, -1 line 0 comments Download
A + Source/platform/KeyCodeConversionAndroid.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + Source/platform/KeyCodeConversionGtk.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/web/WebInputEventFactoryAndroid.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebInputEventFactoryGtk.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/KeyCodeConversionTestGtk.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jbroman
Patch Set 1 is the originally landed patch set (which was reverted); Patch Set 2 ...
7 years ago (2013-12-21 03:43:53 UTC) #1
Dirk Pranke
Ah, somehow I totally missed that the include was missing :(. LGTM.
7 years ago (2013-12-21 03:52:41 UTC) #2
eseidel
lgtm
6 years, 12 months ago (2013-12-27 17:22:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/106103009/40001
6 years, 12 months ago (2013-12-27 17:23:01 UTC) #4
commit-bot: I haz the power
6 years, 12 months ago (2013-12-27 19:02:36 UTC) #5
Message was sent while issue was closed.
Change committed as 164363

Powered by Google App Engine
This is Rietveld 408576698