Issue 111403004: Move remaining KeyCode files to platform/

Issue 111403004: Move remaining KeyCode files to platform/ (Closed)

Created:
7 years ago by pilgrim_google

Modified:
7 years ago

Reviewers:
jamesr, Dirk Pranke, eseidel, darin (slow to review), abarth-chromium, pdr.

CC:
blink-reviews, darin (slow to review)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Move remaining KeyCode files to platform/ BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164107

Patch Set 1 #

Patch Set 2 : rebase #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -812 lines)			Patch
M	Source/core/core.gypi	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
D	Source/core/platform/chromium/KeyCodeConversion.h	View		1 chunk	+0 lines, -40 lines	0 comments	Download
D	Source/core/platform/chromium/KeyCodeConversionAndroid.cpp	View		1 chunk	+0 lines, -329 lines	0 comments	Download
D	Source/core/platform/chromium/KeyCodeConversionGtk.cpp	View		1 chunk	+0 lines, -436 lines	0 comments	Download
A +	Source/platform/KeyCodeConversion.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
A +	Source/platform/KeyCodeConversionAndroid.cpp	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	Source/platform/KeyCodeConversionGtk.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/platform/blink_platform.gypi	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/web/WebInputEventFactoryAndroid.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebInputEventFactoryGtk.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/tests/KeyCodeConversionTestGtk.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

pilgrim_google

If anyone is around this week, could I get a quick review on moving some ...

7 years ago (2013-12-18 14:32:34 UTC) #2

eseidel

lgtm I suspect these are gonna eventually move up into content/ and content/ will talk ...

7 years ago (2013-12-18 16:19:15 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/111403004/20001

7 years ago (2013-12-18 16:19:29 UTC) #4

Wez

On 2013/12/18 16:19:15, eseidel wrote: > lgtm > > I suspect these are gonna eventually ...

7 years ago (2013-12-18 17:20:58 UTC) #5

Dirk Pranke

7 years ago (2013-12-19 02:24:15 UTC) #7

Message was sent while issue was closed.

Unfortunately, it looks like this change doesn't compile on the
android_dbg_clang bot (which you only see when this is picked up by a Blink
roll).

It is not obvious what's wrong with the change; it almost looks like a linker
bug. I've filed crbug.com/329743 with more info.

In the meantime, I need to revert this change to un-block the roll :(.

Sorry!

Expand Messages | Collapse Messages