Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3339)

Unified Diff: chrome/browser/resources/extensions/extensions.js

Issue 1060973004: Enable tests related to the extensions web ui that were flaky. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Apply feedback + fix test Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extensions.js
diff --git a/chrome/browser/resources/extensions/extensions.js b/chrome/browser/resources/extensions/extensions.js
index 48dfa5d5495d0190474538ef9bc847d08ef0a090..5e1812dbf250d7fd4b08858539e1d2b5230dca2b 100644
--- a/chrome/browser/resources/extensions/extensions.js
+++ b/chrome/browser/resources/extensions/extensions.js
@@ -125,6 +125,14 @@ cr.define('extensions', function() {
dragEnabled_: false,
/**
+ * Callback for testing purposes. This is called after the "Developer mode"
+ * checkbox is toggled and the div containing developer buttons' height has
+ * been set.
+ * @type {function()?}
+ */
+ testingDeveloperModeCallback: null,
+
+ /**
* Perform initial setup.
*/
initialize: function() {
@@ -343,6 +351,9 @@ cr.define('extensions', function() {
window.requestAnimationFrame(function() {
devControls.style.height = !showDevControls ? '' :
buttons.offsetHeight + 'px';
+
+ if (this.testingDeveloperModeCallback)
+ this.testingDeveloperModeCallback();
}.bind(this));
},

Powered by Google App Engine
This is Rietveld 408576698