Enable tests related to the extensions web ui that were flaky.

Enable tests related to the extensions web ui that were flaky.

Dedupe code that disables transitions/animations in tests.
Add callback for testing purposes. This callback happens when the
  'Developer mode' toggle has finished resizing the 'dev-controls' div.
Enable ignored a11y audits, testErrorListButtonVisibility, and drmemory.

BUG=463245
Committed: https://crrev.com/9190af788e83ac0c73de9a0eb89e40b681e80436
Cr-Commit-Position: refs/heads/master@{#328415}

[Dan Beam, 2015-04-27 18:29:58]

drive-by

https://codereview.chromium.org/1060973004/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/test_api.js (right):

https://codereview.chromium.org/1060973004/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/test_api.js:227: disableAnimationsAndTransitions:
function() {
make this static

[hcarmona, 2015-04-29 19:11:04]

hcarmona@chromium.org changed reviewers:
+ dbeam@chromium.org, kalman@chromium.org, timurrrr@chromium.org

[hcarmona, 2015-04-29 19:12:32]

Please take a look and provide feedback.

Thanks!

https://codereview.chromium.org/1060973004/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/test_api.js (right):

https://codereview.chromium.org/1060973004/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/test_api.js:227: disableAnimationsAndTransitions:
function() {
On 2015/04/27 18:29:58, Dan Beam wrote:
> make this static

Done.

[not at google - send to devlin, 2015-04-29 22:03:31]

nice

https://codereview.chromium.org/1060973004/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/extensions/extensions.js (right):

https://codereview.chromium.org/1060973004/diff/100001/chrome/browser/resourc...
chrome/browser/resources/extensions/extensions.js:349: if
(this.testingDeveloperModeCallback)
Where is this defined?

https://codereview.chromium.org/1060973004/diff/100001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
(right):

https://codereview.chromium.org/1060973004/diff/100001/chrome/browser/ui/webu...
chrome/browser/ui/webui/extensions/extension_settings_browsertest.js:52:
testing.Test.disableAnimationsAndTransitions();
Should probably re-enable these in tearDown?

[hcarmona, 2015-04-30 18:42:01]

https://codereview.chromium.org/1060973004/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/extensions/extensions.js (right):

https://codereview.chromium.org/1060973004/diff/100001/chrome/browser/resourc...
chrome/browser/resources/extensions/extensions.js:349: if
(this.testingDeveloperModeCallback)
On 2015/04/29 22:03:31, kalman wrote:
> Where is this defined?

Defined now.

https://codereview.chromium.org/1060973004/diff/100001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
(right):

https://codereview.chromium.org/1060973004/diff/100001/chrome/browser/ui/webu...
chrome/browser/ui/webui/extensions/extension_settings_browsertest.js:52:
testing.Test.disableAnimationsAndTransitions();
On 2015/04/29 22:03:31, kalman wrote:
> Should probably re-enable these in tearDown?

These are disabled by injecting CSS into the page.
Since each test reloads the page, is there any benefit to re-enabling?

https://codereview.chromium.org/1060973004/diff/120001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
(right):

https://codereview.chromium.org/1060973004/diff/120001/chrome/browser/ui/webu...
chrome/browser/ui/webui/extensions/extension_settings_browsertest.js:286:
TEST_F('AsyncExtensionSettingsWebUITest', 'testErrorListButtonVisibility',
Extensions UI changed so the list of errors is no longer visible here.
Updated test so it's still valid.

[not at google - send to devlin, 2015-04-30 22:47:10]

lgtm

https://codereview.chromium.org/1060973004/diff/100001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
(right):

https://codereview.chromium.org/1060973004/diff/100001/chrome/browser/ui/webu...
chrome/browser/ui/webui/extensions/extension_settings_browsertest.js:52:
testing.Test.disableAnimationsAndTransitions();
On 2015/04/30 18:42:00, Hector Carmona wrote:
> On 2015/04/29 22:03:31, kalman wrote:
> > Should probably re-enable these in tearDown?
> 
> These are disabled by injecting CSS into the page.
> Since each test reloads the page, is there any benefit to re-enabling?

fair nuff. so long as each test reloads the page. I'm never sure with test
frameworks, some do, some don't.

[Dan Beam, 2015-04-30 23:01:54]

lookin' pretty good to me...

https://codereview.chromium.org/1060973004/diff/100001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
(right):

https://codereview.chromium.org/1060973004/diff/100001/chrome/browser/ui/webu...
chrome/browser/ui/webui/extensions/extension_settings_browsertest.js:52:
testing.Test.disableAnimationsAndTransitions();
On 2015/04/30 22:47:10, kalman wrote:
> On 2015/04/30 18:42:00, Hector Carmona wrote:
> > On 2015/04/29 22:03:31, kalman wrote:
> > > Should probably re-enable these in tearDown?
> > 
> > These are disabled by injecting CSS into the page.
> > Since each test reloads the page, is there any benefit to re-enabling?
> 
> fair nuff. so long as each test reloads the page. I'm never sure with test
> frameworks, some do, some don't.

eh, might as well just remove it every time

https://codereview.chromium.org/1060973004/diff/120001/chrome/test/data/webui...
File chrome/test/data/webui/test_api.js (right):

https://codereview.chromium.org/1060973004/diff/120001/chrome/test/data/webui...
chrome/test/data/webui/test_api.js:50: * listened to.
please note here that no transition end events will work while this style is
applied

https://codereview.chromium.org/1060973004/diff/120001/chrome/test/data/webui...
chrome/test/data/webui/test_api.js:53: var noAnimationStyle =
document.createElement('style');
noAnimationStyle.id = 'no-animation';

https://codereview.chromium.org/1060973004/diff/120001/chrome/test/data/webui...
chrome/test/data/webui/test_api.js:325: tearDown: function() {
var noAnimationStyle = $('no-animation');
if (noAnimationStyle)
  noAnimationStyle.parentNode.removeChild(noAnimationStyle);

[hcarmona, 2015-04-30 23:16:59]

https://codereview.chromium.org/1060973004/diff/100001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
(right):

https://codereview.chromium.org/1060973004/diff/100001/chrome/browser/ui/webu...
chrome/browser/ui/webui/extensions/extension_settings_browsertest.js:52:
testing.Test.disableAnimationsAndTransitions();
On 2015/04/30 23:01:54, Dan Beam wrote:
> On 2015/04/30 22:47:10, kalman wrote:
> > On 2015/04/30 18:42:00, Hector Carmona wrote:
> > > On 2015/04/29 22:03:31, kalman wrote:
> > > > Should probably re-enable these in tearDown?
> > > 
> > > These are disabled by injecting CSS into the page.
> > > Since each test reloads the page, is there any benefit to re-enabling?
> > 
> > fair nuff. so long as each test reloads the page. I'm never sure with test
> > frameworks, some do, some don't.
> 
> eh, might as well just remove it every time

Done.

https://codereview.chromium.org/1060973004/diff/120001/chrome/test/data/webui...
File chrome/test/data/webui/test_api.js (right):

https://codereview.chromium.org/1060973004/diff/120001/chrome/test/data/webui...
chrome/test/data/webui/test_api.js:50: * listened to.
On 2015/04/30 23:01:54, Dan Beam wrote:
> please note here that no transition end events will work while this style is
> applied

Done.

https://codereview.chromium.org/1060973004/diff/120001/chrome/test/data/webui...
chrome/test/data/webui/test_api.js:53: var noAnimationStyle =
document.createElement('style');
On 2015/04/30 23:01:54, Dan Beam wrote:
> noAnimationStyle.id = 'no-animation';

Done.

https://codereview.chromium.org/1060973004/diff/120001/chrome/test/data/webui...
chrome/test/data/webui/test_api.js:325: tearDown: function() {
On 2015/04/30 23:01:54, Dan Beam wrote:
> var noAnimationStyle = $('no-animation');
> if (noAnimationStyle)
>   noAnimationStyle.parentNode.removeChild(noAnimationStyle);

Done.

[Dan Beam, 2015-04-30 23:22:04]

lgtm

https://codereview.chromium.org/1060973004/diff/140001/chrome/test/data/webui...
File chrome/test/data/webui/test_api.js (right):

https://codereview.chromium.org/1060973004/diff/140001/chrome/test/data/webui...
chrome/test/data/webui/test_api.js:50: * listened to.
Make all transitions and animations take 0ms. NOTE: this will completely disable
webkitTransitionEnd events. If your code relies on them firing, it will break.
webkitAnimationEnd events should still work.

[hcarmona, 2015-05-01 16:51:32]

Timur,

Any trybots I should run before re-enabling the drmemory? I ran the
tests locally on my windows machine.

Thanks!

https://codereview.chromium.org/1060973004/diff/140001/chrome/test/data/webui...
File chrome/test/data/webui/test_api.js (right):

https://codereview.chromium.org/1060973004/diff/140001/chrome/test/data/webui...
chrome/test/data/webui/test_api.js:50: * listened to.
On 2015/04/30 23:22:04, Dan Beam wrote:
> Make all transitions and animations take 0ms. NOTE: this will completely
disable
> webkitTransitionEnd events. If your code relies on them firing, it will break.
> webkitAnimationEnd events should still work.

Done.

[Timur Iskhodzhanov, 2015-05-04 18:30:04]

Sorry for a long delay, I haven't seen your email before for some reason.

We don't have any Dr.Memory trybots*.
If it works for you locally, just commit and check the bots [or your inbox] in a
few hours after committing.
If you want double-safety, ask the memory sheriff (build.chromium.org -> Ctrl+F
"Memory:") to watch the status as well.

* – one can figure that out by searching for "dr" and "memory" on
http://build.chromium.org/p/tryserver.chromium.win/builders

[hcarmona, 2015-05-05 16:53:44]

Updated TearDown because document and $ are not always defined.

[Dan Beam, 2015-05-05 16:56:46]

lgtm

https://codereview.chromium.org/1060973004/diff/220001/chrome/test/data/webui...
File chrome/test/data/webui/test_api.js (right):

https://codereview.chromium.org/1060973004/diff/220001/chrome/test/data/webui...
chrome/test/data/webui/test_api.js:327: if (!(typeof document === 'undefined'))
{
if (typeof document != 'undefined') {

[hcarmona, 2015-05-05 21:13:41]

Applied feedback. Committing.

https://codereview.chromium.org/1060973004/diff/220001/chrome/test/data/webui...
File chrome/test/data/webui/test_api.js (right):

https://codereview.chromium.org/1060973004/diff/220001/chrome/test/data/webui...
chrome/test/data/webui/test_api.js:327: if (!(typeof document === 'undefined'))
{
On 2015/05/05 16:56:46, Dan Beam wrote:
> if (typeof document != 'undefined') {

Done.

[hcarmona, 2015-05-05 21:13:48]

The CQ bit was checked by hcarmona@chromium.org

[hcarmona, 2015-05-05 21:13:48]

The patchset sent to the CQ was uploaded after l-g-t-m from kalman@chromium.org,
dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1060973004/#ps240001
(title: "Apply feedback")

[commit-bot: I haz the power, 2015-05-05 21:15:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1060973004/240001

[commit-bot: I haz the power, 2015-05-05 22:01:46]

Committed patchset #13 (id:240001)

[commit-bot: I haz the power, 2015-05-05 22:02:36]

Patchset 13 (id:??) landed as
https://crrev.com/9190af788e83ac0c73de9a0eb89e40b681e80436
Cr-Commit-Position: refs/heads/master@{#328415}

[Nico, 2015-05-06 19:33:11]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-05-06 19:33:12]

testErrorListButtonVisibility  is failing on the clang/win official builder:
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang%20tester/builds/617
(not sure if it's triggered by clang or by it being an official buidl)

[hcarmona, 2015-05-06 23:22:14]

On 2015/05/06 19:33:12, Nico wrote:
> testErrorListButtonVisibility  is failing on the clang/win official builder:
>
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang%20tester/builds/617
> (not sure if it's triggered by clang or by it being an official buidl)

I will create a CL to disable the failing test to get the bot green
again while I continue to investigate this failure.