Enable tests related to the extensions web ui that were flaky.

chrome/browser/ui/webui/extensions/extension_settings_browsertest.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(dbeam): test for loading upacked extensions?
 
 GEN('#include "chrome/browser/ui/webui/extensions/' +
     'extension_settings_browsertest.h"');
 
 // chrome/test/data/extensions/good.crx's extension ID. good.crx is loaded by
@@ skipping 31 matching lines @@
    * @type {string}
    * @const
    */
   browsePreload: 'chrome://extensions-frame/',
 
   /** @override */
   typedefCppFixture: 'ExtensionSettingsUIBrowserTest',
 
   /** @override */
   setUp: function() {
-    // Make all transitions take 0ms for testing purposes.
-    var noTransitionStyle = document.createElement('style');
-    noTransitionStyle.textContent =
-        '* {' +
-        '  -webkit-transition-duration: 0ms !important;' +
-        '  -webkit-transition-delay: 0ms !important;' +
-        '}';
-    document.querySelector('head').appendChild(noTransitionStyle);
+    testing.Test.disableAnimationsAndTransitions();

[not at google - send to devlin, 2015/04/29 22:03:31]

Should probably re-enable these in tearDown?

[hcarmona, 2015/04/30 18:42:00]

These are disabled by injecting CSS into the page.
Since each test reloads the page, is there any benefit to re-enabling?

[not at google - send to devlin, 2015/04/30 22:47:10]

fair nuff. so long as each test reloads the page. I'm never sure with test
frameworks, some do, some don't.

[Dan Beam, 2015/04/30 23:01:54]

eh, might as well just remove it every time

[hcarmona, 2015/04/30 23:16:59]

Done.

   },
 
   /**
    * Holds an array of steps that should happen in order during a test.
    * The last step should be |testDone|.
    * @protected {Array<!Function>}
    * */
   steps: [],
 
   /**
@@ skipping 10 matching lines @@
    * the first step in every test.
    * @protected
    * */
   waitForPageLoad: function() {
     assertEquals(this.browsePreload, document.location.href);
     var extensionList = getRequiredElement('extension-settings-list');
     extensionList.loadFinished.then(this.nextStep.bind(this));
   },
 
   /** @protected */
-  verifyDeveloperModeWorks: function() {
-    this.ignoreDevModeA11yFailures();
+  enableDeveloperMode: function() {
+    var next = this.nextStep.bind(this);
+    extensions.ExtensionSettings.getInstance().testingDeveloperModeCallback =
+        function() {
+      chrome.developerPrivate.getProfileConfiguration(function(profileInfo) {
+        assertTrue(extensionSettings.classList.contains('dev-mode'));
+        assertTrue(profileInfo.inDeveloperMode);
+        next();
+
+        // This event isn't thrown because transitions are disabled.
+        // Ensure transition here so that any dependent code does not break.
+        ensureTransitionEndEvent($('dev-controls'), 0);
+      });
+    };
+
     var extensionSettings = getRequiredElement('extension-settings');
     assertFalse(extensionSettings.classList.contains('dev-mode'));
     $('toggle-dev-on').click();
-    assertTrue(extensionSettings.classList.contains('dev-mode'));
-    chrome.developerPrivate.getProfileConfiguration(function(profileInfo) {
-      assertTrue(profileInfo.inDeveloperMode);
-
-      // A 0ms timeout is necessary so that all the transitions can finish.
-      window.setTimeout(this.nextStep.bind(this), 0);
-    }.bind(this));
   },
 
   /** @protected */
   testDeveloperMode: function() {
     var next = this.nextStep.bind(this);
     var checkDevModeIsOff = function() {
       chrome.developerPrivate.getProfileConfiguration(function(profileInfo) {
         assertFalse(profileInfo.inDeveloperMode);
         next();
       });
     };
     this.steps = [this.waitForPageLoad,
                   checkDevModeIsOff,
-                  this.verifyDeveloperModeWorks,
+                  this.enableDeveloperMode,
                   testDone];
     this.nextStep();
   },
-
-  /**
-   * TODO(hcarmona): Remove this as part of fixing crbug.com/463245.
-   * Will ignore accessibility failures caused by the transition when developer
-   * mode is enabled.
-   * @protected
-   */
-  ignoreDevModeA11yFailures: function() {
-    this.accessibilityAuditConfig.ignoreSelectors(
-          'focusableElementNotVisibleAndNotAriaHidden',
-          '#load-unpacked');
-    this.accessibilityAuditConfig.ignoreSelectors(
-          'focusableElementNotVisibleAndNotAriaHidden',
-          '#pack-extension');
-    this.accessibilityAuditConfig.ignoreSelectors(
-          'focusableElementNotVisibleAndNotAriaHidden',
-          '#update-extensions-now');
-  },
 };
 
 // Verify that developer mode doesn't change behavior when the number of
 // extensions changes.
 TEST_F('ExtensionSettingsWebUITest', 'testDeveloperModeNoExtensions',
        function() {
   this.testDeveloperMode();
 });
 
 TEST_F('ExtensionSettingsWebUITest', 'testEmptyExtensionList', function() {
@@ skipping 129 matching lines @@
   this.steps = [this.waitForPageLoad, this.verifyUninstallWorks, testDone];
   this.nextStep();
 });
 
 TEST_F('BasicExtensionSettingsWebUITest', 'testNonEmptyExtensionList',
        function() {
   var verifyListIsNotHiddenAndEmpty = function() {
     assertFalse($('extension-list-wrapper').hidden);
     assertTrue($('no-extensions').hidden);
     assertGT($('extension-settings-list').childNodes.length, 0);
-
     this.nextStep();
   };
 
   this.steps = [this.waitForPageLoad, verifyListIsNotHiddenAndEmpty, testDone];
   this.nextStep();
 });
 
 function AsyncExtensionSettingsWebUITest() {}
 
 AsyncExtensionSettingsWebUITest.prototype = {
   __proto__: ExtensionSettingsWebUITest.prototype,
 
   /** @override */
   testGenPreamble: function() {
     GEN('  InstallGoodExtension();');
     GEN('  InstallErrorsExtension();');
   },
 };
 
-// Often times out on all platforms: http://crbug.com/467528
-TEST_F('AsyncExtensionSettingsWebUITest',
-       'DISABLED_testErrorListButtonVisibility',
+TEST_F('AsyncExtensionSettingsWebUITest', 'testErrorListButtonVisibility',
     function() {
   var testButtonVisibility = function() {
     // 2 extensions are loaded:
     //   The 'good' extension will have 0 errors wich means no error list
     //     buttons.
     //   The 'bad' extension will have >3 manifest errors and <3 runtime errors.
     //     This means 2 buttons: 1 visible and 1 hidden.
     var visibleButtons = document.querySelectorAll(
         '.extension-error-list-show-more > a:not([hidden])');
-    assertEquals(1, visibleButtons.length);
+    expectEquals(1, visibleButtons.length);
     // Visible buttons must be part of the focusRow.
-    assertTrue(visibleButtons[0].hasAttribute('column-type'));
+    expectTrue(visibleButtons[0] &&
+               visibleButtons[0].hasAttribute('column-type'));
 
     var hiddenButtons = document.querySelectorAll(
         '.extension-error-list-show-more > a[hidden]');
-    assertEquals(1, hiddenButtons.length);
+    expectEquals(1, hiddenButtons.length);
     // Hidden buttons must NOT be part of the focusRow.
-    assertFalse(hiddenButtons[0].hasAttribute('column-type'));
+    expectFalse(hiddenButtons[0] &&
+                hiddenButtons[0].hasAttribute('column-type'));
 
     this.nextStep();
   };
 
   this.steps = [this.waitForPageLoad,
-                this.verifyDeveloperModeWorks,
+                this.enableDeveloperMode,
                 testButtonVisibility,
                 testDone];
   this.nextStep();
 });
 
 /**
  * TestFixture for extension settings WebUI testing (commands config edition).
  * @extends {testing.Test}
  * @constructor
  */
@@ skipping 93 matching lines @@
 
   /** @override */
   browsePreload: ExtensionSettingsWebUITest.prototype.browsePreload +
       '?options=' + GOOD_CRX_ID,
 };
 
 TEST_F('OptionsDialogExtensionSettingsWebUITest', 'testAccessibility',
        function() {
   this.emptyTestForAccessibility();
 });