Issue 1060813008: Handle symbol literals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1060813008: Handle symbol literals (Closed)

Created:
5 years, 8 months ago by vsm

Modified:
5 years, 8 months ago

Reviewers:
Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Handle symbol literals (Hitting this in angular / stack_trace.) R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/431666f977cc37faf2e631440e794b451307daec

Patch Set 2 : Add comment #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	lib/runtime/dart/_js_helper.js	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	lib/src/codegen/js_codegen.dart	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jennifer Messerly

one issue otherwise lgtm https://codereview.chromium.org/1060813008/diff/1/lib/src/codegen/js_codegen.dart File lib/src/codegen/js_codegen.dart (right): https://codereview.chromium.org/1060813008/diff/1/lib/src/codegen/js_codegen.dart#newcode2060 lib/src/codegen/js_codegen.dart:2060: var symbol = js.call('new _internal.Symbol(#)', ...

5 years, 8 months ago (2015-04-21 21:23:35 UTC) #3

vsm

5 years, 8 months ago (2015-04-21 21:49:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
431666f977cc37faf2e631440e794b451307daec (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1060813008: Handle symbol literals (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add comment #

Messages