Handle symbol literals

lib/src/codegen/js_codegen.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dev_compiler.src.codegen.js_codegen;
 
 import 'dart:collection' show HashSet, HashMap;
 
 import 'package:analyzer/analyzer.dart' hide ConstantEvaluator;
 import 'package:analyzer/src/generated/ast.dart' hide ConstantEvaluator;
@@ skipping 2035 matching lines @@
   @override
   visitIntegerLiteral(IntegerLiteral node) => js.number(node.value);
 
   @override
   visitDoubleLiteral(DoubleLiteral node) => js.number(node.value);
 
   @override
   visitNullLiteral(NullLiteral node) => new JS.LiteralNull();
 
   @override
+  visitSymbolLiteral(SymbolLiteral node) {
+    // TODO(vsm): When we canonicalize, we need to treat private symbols
+    // correctly.
+    var name = js.escapedString(node.components.join('.'));
+    var symbol = js.call('new _internal.Symbol(#)', name);

[Jennifer Messerly, 2015/04/21 21:23:35]

this should be core.Symbol right?
(the impl of core.Symbol currently redirects to _internal via factory, but
that's in the patch file, we might very well want to change it...)

+    return js.commentExpression('Unimplemented const', symbol);
+  }
+
+  @override
   visitListLiteral(ListLiteral node) {
     JS.Expression list = new JS.ArrayInitializer(_visitList(node.elements));
 
     ParameterizedType type = node.staticType;
     if (type.typeArguments.any((a) => a != types.dynamicType)) {
       list = js.call('dart.setType(#, #)', [list, _emitTypeName(type)]);
     }
     if (node.constKeyword != null) {
       list = js.commentExpression('Unimplemented const', list);
     }
@@ skipping 318 matching lines @@
   return filepath;
 }
 
 // TODO(jmesserly): validate the library. See issue #135.
 bool _isJsNameAnnotation(DartObjectImpl value) => value.type.name == 'JsName';
 
 // TODO(jacobr): we would like to do something like the following
 // but we don't have summary support yet.
 // bool _supportJsExtensionMethod(AnnotatedNode node) =>
 //    _getAnnotation(node, "SupportJsExtensionMethod") != null;