Replace secure origin warning shortlink with an HTTPS shortlink to an HTTPS URL.

Replace secure origin warning shortlink with an HTTPS shortlink to an HTTPS URL.

Note that it's not sufficient to change the scheme of the current shortlink to HTTPS, because it would still redirect to an HTTP URL.

BUG=400674
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193507

[lgarron, 2015-04-03 20:37:29]

lgarron@chromium.org changed reviewers:
+ mkwst@chromium.org, paulirish@chromium.org

[lgarron, 2015-04-03 20:37:30]

This strikes me as hilariously ironic.

Mike, anything I should know about this submission before submitting this for
review?

Paul, I've never seen a shortlink in DevTools before. Is this common?

[paulirish, 2015-04-03 21:01:04]

Seems good. 

We use links in console messages when appropriate. (See the one for sync XHR)

I'm fine with there being shortlinks. 
"https://www.chromium.org/Home/chromium-security/prefer-secure-origins-for-powerful-new-features"
is unfortunately too long to be dropping into the console. So shortlink it is.

[falken, 2015-04-04 00:39:51]

On 2015/04/03 21:01:04, paulirish wrote:
> Seems good. 
> 
> We use links in console messages when appropriate. (See the one for sync XHR)
> 
> I'm fine with there being shortlinks. 
>
"https://www.chromium.org/Home/chromium-security/prefer-secure-origins-for-powerful-new-features"
> is unfortunately too long to be dropping into the console. So shortlink it is.

While you're here, does it make sense to add "See" before the link? I once got
this message and at first thought goo.gl was the blocked URL.

[lgarron, 2015-04-04 00:42:57]

On 2015/04/04 at 00:39:51, falken wrote:
> On 2015/04/03 21:01:04, paulirish wrote:
> > Seems good. 
> > 
> > We use links in console messages when appropriate. (See the one for sync
XHR)
> > 
> > I'm fine with there being shortlinks. 
> >
"https://www.chromium.org/Home/chromium-security/prefer-secure-origins-for-powerful-new-features"
> > is unfortunately too long to be dropping into the console. So shortlink it
is.
> 
> While you're here, does it make sense to add "See" before the link? I once got
this message and at first thought goo.gl was the blocked URL.

Good idea. Is "See X" clear enough for a broad developer audience, or would
something like "Details at X" be more clear"?

[falken, 2015-04-04 01:01:07]

On 2015/04/04 00:42:57, lgarron wrote:
> On 2015/04/04 at 00:39:51, falken wrote:
> > On 2015/04/03 21:01:04, paulirish wrote:
> > > Seems good. 
> > > 
> > > We use links in console messages when appropriate. (See the one for sync
> XHR)
> > > 
> > > I'm fine with there being shortlinks. 
> > >
>
"https://www.chromium.org/Home/chromium-security/prefer-secure-origins-for-powerful-new-features"
> > > is unfortunately too long to be dropping into the console. So shortlink it
> is.
> > 
> > While you're here, does it make sense to add "See" before the link? I once
got
> this message and at first thought goo.gl was the blocked URL.
> 
> Good idea. Is "See X" clear enough for a broad developer audience, or would
> something like "Details at X" be more clear"?

Maybe following similar messages is good, like the sync XHR's "For more help,
check http://xhr.spec.whatwg.org/."
Calling it "help" is a bit wrong in this case though, maybe "For more details,
check/see"

[paulirish, 2015-04-04 01:10:40]

yeahhh!

​For more details, visit <url>.

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[paulirish, 2015-04-04 01:16:04]

Actually just got this in React and prefer it:
http://i.imgur.com/zEus4UF.png

So something like this feels fine:​

Synchronous XMLHttpRequest on the main thread is deprecated because of its
detrimental effects to the end user's experience. (see:
http://xhr.spec.whatwg.org/ )

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[lgarron, 2015-04-04 01:25:51]

On 2015/04/04 at 01:16:04, paulirish wrote:
> Actually just got this in React and prefer it:
> http://i.imgur.com/zEus4UF.png
> 
> So something like this feels fine:​
> 
> Synchronous XMLHttpRequest on the main thread is deprecated because of its
> detrimental effects to the end user's experience. (see:
> http://xhr.spec.whatwg.org/ )
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email to blink-reviews+unsubscribe@chromium.org.
> 

Hmm, I see. Looks clear and concise enough (even if the lowercase "see" and
missing period at the end of the sentence bother me a bit). Would you like to
start by adopting that convention here, and/or make a new issue for it?

[paulirish, 2015-04-04 01:53:02]

lets kick it off here on this CL.

TBH I dont think we have a lot of console messages to apply this to. But
worth a look.

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Mike West, 2015-04-04 04:44:08]

Changing to `(see: ...)`, and HTTPSizing the links LGTM. :)

Land it as soon as Paul is happy with the patch.

[paulirish, 2015-04-09 08:39:03]

lucas, are you updating the text?

[lgarron, 2015-04-10 02:00:31]

On 2015/04/09 at 08:39:03, paulirish wrote:
> lucas, are you updating the text?

Yep, thanks for the poke.

[lgarron, 2015-04-10 02:19:21]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2015-04-10 02:19:21]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1060723002/#ps20001
(title: "Change link format as discussed.")

[commit-bot: I haz the power, 2015-04-10 02:20:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1060723002/20001

[commit-bot: I haz the power, 2015-04-10 03:57:59]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193507