Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1060583011: Make quoteCSSString an internal helper (Closed)

Created:
5 years, 8 months ago by rwlbuis
Modified:
5 years, 8 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make quoteCSSString an internal helper After r194401 there is only one non-internal caller of quoteCSSString, which for consistency should use serializeString instead. So use that instead and move quoteCSSString out of the public interface. BUG=478775 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194514

Patch Set 1 #

Patch Set 2 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M Source/core/css/CSSMarkup.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSMarkup.cpp View 2 chunks +8 lines, -1 line 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
rwlbuis
PTAL. I'd like to only end up with serializeFoo instead of quoteCSSFoo at some point...
5 years, 8 months ago (2015-04-24 21:43:04 UTC) #2
Timothy Loh
On 2015/04/24 21:43:04, rwlbuis wrote: > PTAL. I'd like to only end up with serializeFoo ...
5 years, 8 months ago (2015-04-26 23:31:22 UTC) #3
rwlbuis
On 2015/04/26 23:31:22, Timothy Loh wrote: > On 2015/04/24 21:43:04, rwlbuis wrote: > > PTAL. ...
5 years, 8 months ago (2015-04-27 00:02:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060583011/20001
5 years, 8 months ago (2015-04-27 13:12:00 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 14:20:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194514

Powered by Google App Engine
This is Rietveld 408576698