Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: Source/core/html/HTMLElement.cpp

Issue 1060583011: Make quoteCSSString an internal helper (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/CSSPrimitiveValue.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2004-2008, 2013, 2014 Apple Inc. All rights reserved. 4 * Copyright (C) 2004-2008, 2013, 2014 Apple Inc. All rights reserved.
5 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 5 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
6 * Copyright (C) 2011 Motorola Mobility. All rights reserved. 6 * Copyright (C) 2011 Motorola Mobility. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 void HTMLElement::applyBorderAttributeToStyle(const AtomicString& value, Mutable StylePropertySet* style) 138 void HTMLElement::applyBorderAttributeToStyle(const AtomicString& value, Mutable StylePropertySet* style)
139 { 139 {
140 addPropertyToPresentationAttributeStyle(style, CSSPropertyBorderWidth, parse BorderWidthAttribute(value), CSSPrimitiveValue::CSS_PX); 140 addPropertyToPresentationAttributeStyle(style, CSSPropertyBorderWidth, parse BorderWidthAttribute(value), CSSPrimitiveValue::CSS_PX);
141 addPropertyToPresentationAttributeStyle(style, CSSPropertyBorderStyle, CSSVa lueSolid); 141 addPropertyToPresentationAttributeStyle(style, CSSPropertyBorderStyle, CSSVa lueSolid);
142 } 142 }
143 143
144 void HTMLElement::mapLanguageAttributeToLocale(const AtomicString& value, Mutabl eStylePropertySet* style) 144 void HTMLElement::mapLanguageAttributeToLocale(const AtomicString& value, Mutabl eStylePropertySet* style)
145 { 145 {
146 if (!value.isEmpty()) { 146 if (!value.isEmpty()) {
147 // Have to quote so the locale id is treated as a string instead of as a CSS keyword. 147 // Have to quote so the locale id is treated as a string instead of as a CSS keyword.
148 addPropertyToPresentationAttributeStyle(style, CSSPropertyWebkitLocale, quoteCSSString(value)); 148 addPropertyToPresentationAttributeStyle(style, CSSPropertyWebkitLocale, serializeString(value));
149 149
150 // FIXME: Remove the following UseCounter code when we collect enough 150 // FIXME: Remove the following UseCounter code when we collect enough
151 // data. 151 // data.
152 UseCounter::count(document(), UseCounter::LangAttribute); 152 UseCounter::count(document(), UseCounter::LangAttribute);
153 if (isHTMLHtmlElement(*this)) 153 if (isHTMLHtmlElement(*this))
154 UseCounter::count(document(), UseCounter::LangAttributeOnHTML); 154 UseCounter::count(document(), UseCounter::LangAttributeOnHTML);
155 else if (isHTMLBodyElement(*this)) 155 else if (isHTMLBodyElement(*this))
156 UseCounter::count(document(), UseCounter::LangAttributeOnBody); 156 UseCounter::count(document(), UseCounter::LangAttributeOnBody);
157 String htmlLanguage = value.string(); 157 String htmlLanguage = value.string();
158 size_t firstSeparator = htmlLanguage.find('-'); 158 size_t firstSeparator = htmlLanguage.find('-');
(...skipping 854 matching lines...) Expand 10 before | Expand all | Expand 10 after
1013 #ifndef NDEBUG 1013 #ifndef NDEBUG
1014 1014
1015 // For use in the debugger 1015 // For use in the debugger
1016 void dumpInnerHTML(blink::HTMLElement*); 1016 void dumpInnerHTML(blink::HTMLElement*);
1017 1017
1018 void dumpInnerHTML(blink::HTMLElement* element) 1018 void dumpInnerHTML(blink::HTMLElement* element)
1019 { 1019 {
1020 printf("%s\n", element->innerHTML().ascii().data()); 1020 printf("%s\n", element->innerHTML().ascii().data());
1021 } 1021 }
1022 #endif 1022 #endif
OLDNEW
« no previous file with comments | « Source/core/css/CSSPrimitiveValue.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698