Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1060573003: DevTools: cleanup unused method and constants (Closed)

Created:
5 years, 8 months ago by lushnikov
Modified:
5 years, 8 months ago
Reviewers:
Tom Sepez, dgozman
CC:
chromium-reviews, aandrey+blink_chromium.org, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@refactor
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: cleanup unused method and constants Those became unused after DevTools migrated onto RecordEnumeratedHistogram method (via patches r324219 in Chromium and r193409 in Blink). BUG=468026 R=dgozman Committed: https://crrev.com/1487cb3214949531086cd4ee6ec1f716b7359f45 Cr-Commit-Position: refs/heads/master@{#324606}

Patch Set 1 #

Patch Set 2 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M chrome/browser/devtools/devtools_embedder_message_dispatcher.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_embedder_message_dispatcher.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 1 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
lushnikov
PTAL. This patch should be landed after the webkit rolled over https://codereview.chromium.org/1061503002/
5 years, 8 months ago (2015-04-03 14:46:57 UTC) #1
dgozman
lgtm
5 years, 8 months ago (2015-04-03 15:36:49 UTC) #2
lushnikov
tsepez@chromium.org: Please review changes in chrome/browser/devtools/
5 years, 8 months ago (2015-04-09 10:34:39 UTC) #4
Tom Sepez
RS LGTM on deleting code. Thanks for the cleanup.
5 years, 8 months ago (2015-04-09 18:06:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060573003/20001
5 years, 8 months ago (2015-04-10 08:58:47 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-10 09:51:40 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 09:52:31 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1487cb3214949531086cd4ee6ec1f716b7359f45
Cr-Commit-Position: refs/heads/master@{#324606}

Powered by Google App Engine
This is Rietveld 408576698