Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4911)

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.cc

Issue 1060573003: DevTools: cleanup unused method and constants (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor
Patch Set: rebaseline Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_ui_bindings.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_ui_bindings.cc
diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc
index 50f8b048380fbd8eeb5c309bba9c544a47a189a9..294b9c29a24c45a7d158fd6d12dd8c7a5ef7a1f5 100644
--- a/chrome/browser/devtools/devtools_ui_bindings.cc
+++ b/chrome/browser/devtools/devtools_ui_bindings.cc
@@ -71,9 +71,7 @@ static const char kFrontendHostParams[] = "params";
static const char kTitleFormat[] = "Developer Tools - %s";
static const char kDevToolsActionTakenHistogram[] = "DevTools.ActionTaken";
-static const int kDevToolsActionTakenBoundary = 100;
static const char kDevToolsPanelShownHistogram[] = "DevTools.PanelShown";
-static const int kDevToolsPanelShownBoundary = 20;
// This constant should be in sync with
// the constant at shell_devtools_frontend.cc.
@@ -742,13 +740,6 @@ void DevToolsUIBindings::SendMessageToBrowser(const std::string& message) {
agent_host_->DispatchProtocolMessage(message);
}
-void DevToolsUIBindings::RecordActionUMA(const std::string& name, int action) {
- if (name == kDevToolsActionTakenHistogram)
- UMA_HISTOGRAM_ENUMERATION(name, action, kDevToolsActionTakenBoundary);
- else if (name == kDevToolsPanelShownHistogram)
- UMA_HISTOGRAM_ENUMERATION(name, action, kDevToolsPanelShownBoundary);
-}
-
void DevToolsUIBindings::RecordEnumeratedHistogram(const std::string& name,
int sample,
int boundary_value) {
« no previous file with comments | « chrome/browser/devtools/devtools_ui_bindings.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698