chrome/browser/password_manager/password_manager.cc - Issue 106053008: [Mac] Passwords: Don't always prompt to access passwords saved by other browsers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_manager.cc

Issue 106053008: [Mac] Passwords: Don't always prompt to access passwords saved by other browsers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix yet another compile failure. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_form_manager_unittest.cc ('k') | chrome/browser/password_manager/password_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_manager.cc

diff --git a/chrome/browser/password_manager/password_manager.cc b/chrome/browser/password_manager/password_manager.cc

index d19428ef0fd3b849eed42d8d753f25c63b701160..f1a634748afdddeabd3c81cdc53b4c0e6a56bd85 100644

--- a/chrome/browser/password_manager/password_manager.cc

+++ b/chrome/browser/password_manager/password_manager.cc

@@ -326,7 +326,14 @@ void PasswordManager::OnPasswordFormsParsed(

*iter,

ssl_valid);

pending_login_managers_.push_back(manager);

- manager->FetchMatchingLoginsFromPasswordStore();

+ // Avoid prompting the user for access to a password if they don't have

+ // password saving enabled.

+ PasswordStore::AuthorizationPromptPolicy prompt_policy =

+ *password_manager_enabled_ ? PasswordStore::ALLOW_PROMPT

+ : PasswordStore::DISALLOW_PROMPT;

+ manager->FetchMatchingLoginsFromPasswordStore(prompt_policy);

}