Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: chrome/browser/password_manager/password_manager.cc

Issue 106053008: [Mac] Passwords: Don't always prompt to access passwords saved by other browsers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix yet another compile failure. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/password_manager.h" 5 #include "chrome/browser/password_manager/password_manager.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/metrics/field_trial.h" 8 #include "base/metrics/field_trial.h"
9 #include "base/metrics/histogram.h" 9 #include "base/metrics/histogram.h"
10 #include "base/prefs/pref_service.h" 10 #include "base/prefs/pref_service.h"
(...skipping 308 matching lines...) Expand 10 before | Expand all | Expand 10 after
319 continue; 319 continue;
320 320
321 bool ssl_valid = iter->origin.SchemeIsSecure() && !had_ssl_error; 321 bool ssl_valid = iter->origin.SchemeIsSecure() && !had_ssl_error;
322 PasswordFormManager* manager = 322 PasswordFormManager* manager =
323 new PasswordFormManager(delegate_->GetProfile(), 323 new PasswordFormManager(delegate_->GetProfile(),
324 this, 324 this,
325 web_contents(), 325 web_contents(),
326 *iter, 326 *iter,
327 ssl_valid); 327 ssl_valid);
328 pending_login_managers_.push_back(manager); 328 pending_login_managers_.push_back(manager);
329 manager->FetchMatchingLoginsFromPasswordStore(); 329
330 // Avoid prompting the user for access to a password if they don't have
331 // password saving enabled.
332 PasswordStore::AuthorizationPromptPolicy prompt_policy =
333 *password_manager_enabled_ ? PasswordStore::ALLOW_PROMPT
334 : PasswordStore::DISALLOW_PROMPT;
335
336 manager->FetchMatchingLoginsFromPasswordStore(prompt_policy);
330 } 337 }
331 } 338 }
332 339
333 bool PasswordManager::ShouldShowSavePasswordInfoBar() const { 340 bool PasswordManager::ShouldShowSavePasswordInfoBar() const {
334 return provisional_save_manager_->IsNewLogin() && 341 return provisional_save_manager_->IsNewLogin() &&
335 !provisional_save_manager_->HasGeneratedPassword() && 342 !provisional_save_manager_->HasGeneratedPassword() &&
336 !provisional_save_manager_->IsPendingCredentialsPublicSuffixMatch(); 343 !provisional_save_manager_->IsPendingCredentialsPublicSuffixMatch();
337 } 344 }
338 345
339 void PasswordManager::OnPasswordFormsRendered( 346 void PasswordManager::OnPasswordFormsRendered(
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
452 } 459 }
453 460
454 ManagePasswordsBubbleUIController* manage_passwords_bubble_ui_controller = 461 ManagePasswordsBubbleUIController* manage_passwords_bubble_ui_controller =
455 ManagePasswordsBubbleUIController::FromWebContents(web_contents()); 462 ManagePasswordsBubbleUIController::FromWebContents(web_contents());
456 if (manage_passwords_bubble_ui_controller && 463 if (manage_passwords_bubble_ui_controller &&
457 CommandLine::ForCurrentProcess()->HasSwitch( 464 CommandLine::ForCurrentProcess()->HasSwitch(
458 switches::kEnableSavePasswordBubble)) { 465 switches::kEnableSavePasswordBubble)) {
459 manage_passwords_bubble_ui_controller->OnPasswordAutofilled(best_matches); 466 manage_passwords_bubble_ui_controller->OnPasswordAutofilled(best_matches);
460 } 467 }
461 } 468 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698