Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1060113002: Revert of RenderFlexibleBox should be treated as a candidate for visible position. (Closed)

Created:
5 years, 8 months ago by eae
Modified:
5 years, 8 months ago
Reviewers:
Manuel Rego, sof, changseok
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of RenderFlexibleBox should be treated as a candidate for visible position. (patchset #1 id:1 of https://codereview.chromium.org/897633002/) Reason for revert: Revert for now until the fix is ready. Will also be reverted on release branch. Original issue's description: > RenderFlexibleBox should be treated as a candidate for visible position. > > Visible selection in an editable area is recalculated whenever an inner value of div is changed. > If the inner value is empty, the visible selection recalculated with DeleteSelectionCommand::m_endingPostion > is not correct. Because RenderBlockFlow is only considered but not RenderFlexibleBox in Position::isCandidate > so that a calculated ending VisiblePosition for an editable div having ‘display : flex’ goes weird > and VisibleSelection is empty accordingly. > > BUG=450617 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189482 TBR=sigbjornf@opera.com,rego@igalia.com,shivamidow@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=450617 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193212

Patch Set 1 #

Patch Set 2 : Manual revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -54 lines) Patch
D LayoutTests/fast/events/key-events-in-editable-flexbox.html View 1 1 chunk +0 lines, -46 lines 0 comments Download
D LayoutTests/fast/events/key-events-in-editable-flexbox-expected.txt View 1 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/dom/Position.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
eae
Created Revert of RenderFlexibleBox should be treated as a candidate for visible position.
5 years, 8 months ago (2015-04-06 19:41:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060113002/1
5 years, 8 months ago (2015-04-06 19:42:20 UTC) #2
commit-bot: I haz the power
Failed to apply patch for Source/core/dom/Position.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 8 months ago (2015-04-06 19:42:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060113002/90001
5 years, 8 months ago (2015-04-06 20:39:56 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:90001) as https://src.chromium.org/viewvc/blink?view=rev&revision=193212
5 years, 8 months ago (2015-04-06 20:40:41 UTC) #8
changseok
5 years, 8 months ago (2015-04-09 04:23:10 UTC) #9
Message was sent while issue was closed.
On 2015/04/06 20:40:41, I haz the power (commit-bot) wrote:
> Committed patchset #2 (id:90001) as
> https://src.chromium.org/viewvc/blink?view=rev&revision=193212

According to https://codereview.chromium.org/1057953002/#msg20
We can reland the original cl. 
How can I do it?
Do I need to submit another cl or is there any convenient way I don't know? =)

Powered by Google App Engine
This is Rietveld 408576698