Issue 1060053002: [WIP] Support opening an inspector window for ServiceWorker running on Android (chromium)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1060053002: [WIP] Support opening an inspector window for ServiceWorker running on Android (chromium)

Created:
5 years, 8 months ago by horo

Modified:
5 years, 8 months ago

Reviewers:

CC:
chromium-reviews, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, kinuko+watch, aandrey+blink_chromium.org, pfeldman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[WIP] Support opening an inspector window for ServiceWorker running on Android (chromium) BUG=474457

Patch Set 1 #

Patch Set 2 : hack #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : rebase #

Patch Set 9 : fix crash #

Patch Set 10 : json request #

Patch Set 11 : same sa 9 #

Patch Set 12 : #

Patch Set 13 : #

Patch Set 14 : add log #

Patch Set 15 : log #

Patch Set 16 : fix bug in AndroidDeviceManager::AndroidWebSocket #

Patch Set 17 : remove logs #

Patch Set 18 : rebase #

Patch Set 19 : #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+232 lines, -65 lines)			Patch
M	chrome/browser/devtools/device/android_device_manager.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/devtools/device/android_device_manager.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18	4 chunks	+18 lines, -12 lines	0 comments	Download
M	chrome/browser/devtools/device/android_web_socket.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18	6 chunks	+23 lines, -12 lines	0 comments	Download
M	chrome/browser/devtools/device/devtools_android_bridge.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16	10 chunks	+89 lines, -28 lines	0 comments	Download
M	chrome/browser/devtools/devtools_embedder_message_dispatcher.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/devtools/devtools_embedder_message_dispatcher.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/devtools/devtools_ui_bindings.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/devtools/devtools_ui_bindings.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17	1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/browser/devtools/forwarding_agent_host.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/devtools/forwarding_agent_host.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	content/browser/devtools/ipc_devtools_agent_host.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/browser/devtools/ipc_devtools_agent_host.cc	View	1 2 3	2 chunks	+15 lines, -0 lines	0 comments	Download
M	content/browser/devtools/protocol/service_worker_handler.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/devtools/protocol/service_worker_handler.cc	View	1 2 3 4	4 chunks	+25 lines, -2 lines	0 comments	Download
M	content/browser/devtools/service_worker_devtools_manager.cc	View	1 2 3 4 5 6 7 8	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/service_worker/service_worker_context_core.cc	View	1 2	1 chunk	+6 lines, -3 lines	0 comments	Download
M	content/browser/service_worker/service_worker_context_observer.h	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
M	content/browser/service_worker/service_worker_context_watcher.h	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
M	content/browser/service_worker/service_worker_context_watcher.cc	View	1 2	1 chunk	+7 lines, -1 line	0 comments	Download
M	content/browser/service_worker/service_worker_internals_ui.cc	View	1 2	1 chunk	+6 lines, -2 lines	0 comments	Download
M	content/public/browser/devtools_agent_host.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/public/browser/devtools_external_agent_proxy_delegate.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Patchset #17 (id:310001) has been deleted

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages