content/browser/service_worker/service_worker_context_core.cc - Issue 1060053002: [WIP] Support opening an inspector window for ServiceWorker running on Android (chromium)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_core.cc

Issue 1060053002: [WIP] Support opening an inspector window for ServiceWorker running on Android (chromium) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/service_worker_devtools_manager.cc ('k') | content/browser/service_worker/service_worker_context_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_core.cc

diff --git a/content/browser/service_worker/service_worker_context_core.cc b/content/browser/service_worker/service_worker_context_core.cc

index b30238d1e882da13224e6673710d5b10030e7345..b50750c55e7b3b9952b40015d0f45e728b22734e 100644

--- a/content/browser/service_worker/service_worker_context_core.cc

+++ b/content/browser/service_worker/service_worker_context_core.cc

@@ -489,9 +489,12 @@ void ServiceWorkerContextCore::OnRunningStateChanged(

ServiceWorkerVersion* version) {

if (!observer_list_.get())

return;

- observer_list_->Notify(FROM_HERE,

- &ServiceWorkerContextObserver::OnRunningStateChanged,

- version->version_id(), version->running_status());

+ observer_list_->Notify(

+ FROM_HERE, &ServiceWorkerContextObserver::OnRunningStateChanged,

+ version->version_id(), version->running_status(),

+ version->embedded_worker()->process_id(),

+ version->embedded_worker()->thread_id(),

+ version->embedded_worker()->worker_devtools_agent_route_id());

}

void ServiceWorkerContextCore::OnVersionStateChanged(