Issue 1059973004: favor DCHECK_CURRENTLY_ON for better logs in extensions/

Issue 1059973004: favor DCHECK_CURRENTLY_ON for better logs in extensions/ (Closed)

Created:
5 years, 8 months ago by anujsharma

Modified:
5 years, 8 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Mostyn Bramley-Moore

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

favor DCHECK_CURRENTLY_ON for better logs in extensions/ BUG=466848 Committed: https://crrev.com/34e31a3304700639296125e481bc2cc63e77d348 Cr-Commit-Position: refs/heads/master@{#325974}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -11 lines)			Patch
M	extensions/browser/api/bluetooth/bluetooth_event_router.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	extensions/browser/api/bluetooth_socket/bluetooth_socket_api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/browser/api/socket/tls_socket.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/browser/api/sockets_tcp/sockets_tcp_api.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	extensions/browser/guest_view/web_view/web_view_guest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/shell/browser/shell_browser_context.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/shell/browser/shell_oauth2_token_service.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 8 (2 generated)

anujsharma

On 2015/04/20 16:16:38, kalman wrote: > lgtm Thanks kalman for lgtm.

5 years, 8 months ago (2015-04-21 02:11:02 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059973004/1

5 years, 8 months ago (2015-04-21 02:11:28 UTC) #6

commit-bot: I haz the power

5 years, 8 months ago (2015-04-21 03:11:33 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/34e31a3304700639296125e481bc2cc63e77d348
Cr-Commit-Position: refs/heads/master@{#325974}