extensions/browser/api/socket/tls_socket.cc - Issue 1059973004: favor DCHECK_CURRENTLY_ON for better logs in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/socket/tls_socket.cc

Issue 1059973004: favor DCHECK_CURRENTLY_ON for better logs in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/bluetooth_socket/bluetooth_socket_api.cc ('k') | extensions/browser/api/sockets_tcp/sockets_tcp_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/socket/tls_socket.cc

diff --git a/extensions/browser/api/socket/tls_socket.cc b/extensions/browser/api/socket/tls_socket.cc

index 9115c7392828fa042f88a800c5f9526d82b3cd40..9ee15ed91289dd058c3a5f53c091389b9c1b5fb3 100644

--- a/extensions/browser/api/socket/tls_socket.cc

+++ b/extensions/browser/api/socket/tls_socket.cc

@@ -184,7 +184,7 @@ void TLSSocket::UpgradeSocketToTLS(

const std::string& extension_id,

core_api::socket::SecureOptions* options,

const TLSSocket::SecureCallback& callback) {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::IO);

TCPSocket* tcp_socket = static_cast<TCPSocket*>(socket);

scoped_ptr<net::SSLClientSocket> null_sock;