components/favicon/core/favicon_driver.h - Issue 1059743003: Remove NOTIFICATION_FAVICON_UPDATED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/core/favicon_driver.h

Issue 1059743003: Remove NOTIFICATION_FAVICON_UPDATED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@get-active-title

Patch Set: Address comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/favicon/core/favicon_driver.h

diff --git a/components/favicon/core/favicon_driver.h b/components/favicon/core/favicon_driver.h

index 59fc333def57a0af7356046c3c122f40286916bf..5c80d6581230c497e863e73386155320ea1f02e1 100644

--- a/components/favicon/core/favicon_driver.h

+++ b/components/favicon/core/favicon_driver.h

@@ -74,6 +74,10 @@ class FaviconDriver {

const GURL& icon_url,

bool is_active_favicon) = 0;

+ // Sends notification that the current page favicon change. |icon_url_changed|

Bernhard Bauer 2015/04/07 11:28:00 Nit: "... the current page favicon has changed".

sdefresne 2015/04/07 16:54:54 Done.

+ // is true if the URL of the favicon changed in addition to the favicon image.

+ virtual void NotifyFaviconUpdated(bool icon_url_changed) = 0;

protected:

FaviconDriver() {}

virtual ~FaviconDriver() {}