Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: components/favicon/core/favicon_driver.h

Issue 1059743003: Remove NOTIFICATION_FAVICON_UPDATED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@get-active-title
Patch Set: Address comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_H_ 5 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_H_
6 #define COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_H_ 6 #define COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/strings/string16.h" 9 #include "base/strings/string16.h"
10 10
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 virtual void SetActiveFaviconImage(const gfx::Image& image) = 0; 67 virtual void SetActiveFaviconImage(const gfx::Image& image) = 0;
68 68
69 // Notifies the driver a favicon image is available. |image| is not 69 // Notifies the driver a favicon image is available. |image| is not
70 // necessarily 16x16. |icon_url| is the url the image is from. If 70 // necessarily 16x16. |icon_url| is the url the image is from. If
71 // |is_active_favicon| is true the image corresponds to the favicon 71 // |is_active_favicon| is true the image corresponds to the favicon
72 // (possibly empty) of the page. 72 // (possibly empty) of the page.
73 virtual void OnFaviconAvailable(const gfx::Image& image, 73 virtual void OnFaviconAvailable(const gfx::Image& image,
74 const GURL& icon_url, 74 const GURL& icon_url,
75 bool is_active_favicon) = 0; 75 bool is_active_favicon) = 0;
76 76
77 // Sends notification that the current page favicon change. |icon_url_changed|
Bernhard Bauer 2015/04/07 11:28:00 Nit: "... the current page favicon has changed".
sdefresne 2015/04/07 16:54:54 Done.
78 // is true if the URL of the favicon changed in addition to the favicon image.
79 virtual void NotifyFaviconUpdated(bool icon_url_changed) = 0;
80
77 protected: 81 protected:
78 FaviconDriver() {} 82 FaviconDriver() {}
79 virtual ~FaviconDriver() {} 83 virtual ~FaviconDriver() {}
80 84
81 private: 85 private:
82 DISALLOW_COPY_AND_ASSIGN(FaviconDriver); 86 DISALLOW_COPY_AND_ASSIGN(FaviconDriver);
83 }; 87 };
84 88
85 } // namespace favicon 89 } // namespace favicon
86 90
87 #endif // COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_H_ 91 #endif // COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_H_
OLDNEW
« no previous file with comments | « chrome/browser/prerender/prerender_browsertest.cc ('k') | components/favicon/core/favicon_driver_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698