chrome/browser/favicon/favicon_tab_helper.h - Issue 1059743003: Remove NOTIFICATION_FAVICON_UPDATED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_tab_helper.h

Issue 1059743003: Remove NOTIFICATION_FAVICON_UPDATED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@get-active-title

Patch Set: Address comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/favicon/favicon_tab_helper.h

diff --git a/chrome/browser/favicon/favicon_tab_helper.h b/chrome/browser/favicon/favicon_tab_helper.h

index 8c3e58635df14f4e5fe6550e25060764a4000f49..537ee406a3b21dc04d1b6f70a497e12bc11b1403 100644

--- a/chrome/browser/favicon/favicon_tab_helper.h

+++ b/chrome/browser/favicon/favicon_tab_helper.h

@@ -102,6 +102,7 @@ class FaviconTabHelper : public content::WebContentsObserver,

void OnFaviconAvailable(const gfx::Image& image,

const GURL& url,

bool is_active_favicon) override;

+ void NotifyFaviconUpdated(bool icon_url_changed) override;

// Favicon download callback.

void DidDownloadFavicon(