Remove NOTIFICATION_FAVICON_UPDATED

Remove NOTIFICATION_FAVICON_UPDATED

Change notification NOTIFICATION_FAVICON_UPDATED into an event sent to
FaviconDriverObserver and change client code to be observers instead.

Pass the FaviconDriver to OnFaviconUpdated() event so that listeners can
find the content::WebContents corresponding to the event (as some of the
client code did listen to multiple content::WebContents).

BUG=362072
Committed: https://crrev.com/b0befeec4f82ae3bc79c53d69ce91b52d466f044
Cr-Commit-Position: refs/heads/master@{#324201}

[sdefresne, 2015-04-03 14:45:15]

Patchset #1 (id:1) has been deleted

[sdefresne, 2015-04-03 14:52:47]

sdefresne@chromium.org changed reviewers:
+ bauerb@chromium.org, jif@chromium.org, jochen@chromium.org,
kalman@chromium.org

[sdefresne, 2015-04-03 14:53:34]

jif: please take a look

bauerb: please review as OWNERS of
  chrome/browser/android/tab_android.cc
  chrome/browser/android/tab_android.h

jochen: please review as OWNERS of
  chrome/browser/chrome_notification_types.h
  chrome/browser/prerender/prerender_browsertest.cc

kalman: please review as OWNERS of
  chrome/browser/extensions/api/tabs/tabs_event_router.cc
  chrome/browser/extensions/api/tabs/tabs_event_router.h

[not at google - send to devlin, 2015-04-03 16:10:43]

extensions lgtm

[jif, 2015-04-07 07:25:15]

lgtm with comment.

https://codereview.chromium.org/1059743003/diff/20001/chrome/browser/android/...
File chrome/browser/android/tab_android.h (right):

https://codereview.chromium.org/1059743003/diff/20001/chrome/browser/android/...
chrome/browser/android/tab_android.h:142: void
OnFaviconUpdated(favicon::FaviconDriver*,
add name of parameter.

[sdefresne, 2015-04-07 09:17:54]

sdefresne@chromium.org changed reviewers:
+ sky@chromium.org
- jochen@chromium.org

[sdefresne, 2015-04-07 09:18:13]

sky: please review as OWNERS of
  chrome/browser/chrome_notification_types.h
  chrome/browser/prerender/prerender_browsertest.cc

[Bernhard Bauer, 2015-04-07 11:28:00]

android LGTM

https://codereview.chromium.org/1059743003/diff/40001/components/favicon/core...
File components/favicon/core/favicon_driver.h (right):

https://codereview.chromium.org/1059743003/diff/40001/components/favicon/core...
components/favicon/core/favicon_driver.h:77: // Sends notification that the
current page favicon change. |icon_url_changed|
Nit: "... the current page favicon has changed".

[sdefresne, 2015-04-07 16:40:27]

sdefresne@chromium.org changed reviewers:
+ jochen@chromium.org
- sky@chromium.org

[sdefresne, 2015-04-07 16:40:40]

jochen: please review as OWNERS of
  chrome/browser/chrome_notification_types.h
  chrome/browser/prerender/prerender_browsertest.cc

[sdefresne, 2015-04-07 16:54:55]

https://codereview.chromium.org/1059743003/diff/40001/components/favicon/core...
File components/favicon/core/favicon_driver.h (right):

https://codereview.chromium.org/1059743003/diff/40001/components/favicon/core...
components/favicon/core/favicon_driver.h:77: // Sends notification that the
current page favicon change. |icon_url_changed|
On 2015/04/07 11:28:00, Bernhard Bauer wrote:
> Nit: "... the current page favicon has changed".

Done.

[jochen (gone - plz use gerrit), 2015-04-07 19:03:25]

lgtm

https://codereview.chromium.org/1059743003/diff/60001/chrome/browser/prerende...
File chrome/browser/prerender/prerender_browsertest.cc (right):

https://codereview.chromium.org/1059743003/diff/60001/chrome/browser/prerende...
chrome/browser/prerender/prerender_browsertest.cc:168: };
nit. DISALLOW_COPY_AND_ASSIGN()

[sdefresne, 2015-04-08 07:53:12]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2015-04-08 07:53:12]

The patchset sent to the CQ was uploaded after l-g-t-m from jif@chromium.org,
kalman@chromium.org, bauerb@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1059743003/#ps80001
(title: "Add DISALLOW_COPY_AND_ASSIGN(FaviconUpdateWatcher)")

[commit-bot: I haz the power, 2015-04-08 07:53:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1059743003/80001

[commit-bot: I haz the power, 2015-04-08 09:22:18]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-04-08 09:23:31]

Patchset 4 (id:??) landed as
https://crrev.com/b0befeec4f82ae3bc79c53d69ce91b52d466f044
Cr-Commit-Position: refs/heads/master@{#324201}