Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1059633003: Revert of Change V8 to branch 4.3 for M43 (Closed)

Created:
5 years, 8 months ago by alph
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change V8 to branch 4.3 for M43 (patchset #1 id:1 of https://codereview.chromium.org/1058943003/) Reason for revert: Painted entire blink tree red because of broken: http/tests/security/window-named-proto.html http/tests/security/xss-exception.html See: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/28188 http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showLargeExpectations=true&tests=window-named-proto.html%2Chttp%2Ftests%2Fsecurity%2Fxss-exception.html Original issue's description: > Change V8 to branch 4.3 for M43 > > This is a reland of the previous roll (crrev.com/1052993002) which got > reverted due to an errant Blink change that depended on a newer version > of the V8 API. That Blink change has since been reverted. > > R=hablich@chromium.org, machenbach@chromium.org > TBR=hablich@chromium.org, machenbach@chromium.org, vogelheim@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/81d4867666467192685ae572de885796fe79c39a TBR=hablich@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/2760cace1648b215559e0b915d284f7b2345e492 Cr-Commit-Position: refs/heads/master@{#323650}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
alph
Created Revert of Change V8 to branch 4.3 for M43
5 years, 8 months ago (2015-04-03 07:04:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059633003/1
5 years, 8 months ago (2015-04-03 07:05:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-03 07:08:33 UTC) #3
Jakob Kummerow
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1060543003/ by jkummerow@chromium.org. ...
5 years, 8 months ago (2015-04-03 11:27:26 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:33:30 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2760cace1648b215559e0b915d284f7b2345e492
Cr-Commit-Position: refs/heads/master@{#323650}

Powered by Google App Engine
This is Rietveld 408576698