Issue 1050993005: Rebaseline layout tests after V8 roll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1050993005: Rebaseline layout tests after V8 roll (Closed)

Created:
5 years, 8 months ago by kozy

Modified:
5 years, 8 months ago

Reviewers:
pfeldman

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Rebaseline layout tests after V8 roll TBR=pfeldman@chromium.org NOTRY=true BUG=467386 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193012

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -7 lines)			Patch
M	LayoutTests/TestExpectations	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	LayoutTests/http/tests/security/window-named-proto-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/http/tests/security/xss-exception-expected.txt	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1050993005/1

5 years, 8 months ago (2015-04-02 08:42:57 UTC) #3

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=193012

5 years, 8 months ago (2015-04-02 08:44:05 UTC) #4

Jakob Kummerow

5 years, 8 months ago (2015-04-03 11:31:28 UTC) #5

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1052353005/ by jkummerow@chromium.org.

The reason for reverting is: This expectation change prevents rolling V8 in
Chromium trunk back to the V8 version that will be used in the M43 branch (which
was in Chromium trunk earlier this week). Please don't bake in newer
expectations until after the branch point..

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages