Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: src/x64/macro-assembler-x64.cc

Issue 1059543004: Revert of [x64] Use xorl to materialize smi zero. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/x64/macro-assembler-x64.cc
diff --git a/src/x64/macro-assembler-x64.cc b/src/x64/macro-assembler-x64.cc
index 6e23d2913c023d14717a16833ebcbbc9316a2176..f9b3f39ac90e024e799a70f7863e7d79f4ef4adc 100644
--- a/src/x64/macro-assembler-x64.cc
+++ b/src/x64/macro-assembler-x64.cc
@@ -915,7 +915,6 @@
Register MacroAssembler::GetSmiConstant(Smi* source) {
- STATIC_ASSERT(kSmiTag == 0);
int value = source->value();
if (value == 0) {
xorl(kScratchRegister, kScratchRegister);
@@ -927,13 +926,7 @@
void MacroAssembler::LoadSmiConstant(Register dst, Smi* source) {
- STATIC_ASSERT(kSmiTag == 0);
- int value = source->value();
- if (value == 0) {
- xorl(dst, dst);
- } else {
- Move(dst, source, Assembler::RelocInfoNone());
- }
+ Move(dst, source, Assembler::RelocInfoNone());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698