Make MojoResults positive.

Make MojoResults positive.

Step 1 of:

https://docs.google.com/document/d/1A5QL20LzfRDOmsQKyHnA5HK1ZlmrLwAQO9y98GiDNyI

(Also: Roll the network service to a custom build created from
https://crrev.com/1058033002/#ps1)

R=jamesr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/3e048088e59228fa3f5ddcd69ce2b4119c8cdaa5

[jamesr, 2015-04-02 19:58:22]

lgtm

[viettrungluu, 2015-04-02 20:05:36]

Committed patchset #1 (id:1) manually as
3e048088e59228fa3f5ddcd69ce2b4119c8cdaa5 (presubmit successful).

[tonyg, 2015-04-02 20:50:17]

tonyg@chromium.org changed reviewers:
+ tonyg@chromium.org

[tonyg, 2015-04-02 20:50:18]

https://codereview.chromium.org/1059543002/diff/1/mojo/services/network/publi...
File mojo/services/network/public/interfaces/BUILD.gn (left):

https://codereview.chromium.org/1059543002/diff/1/mojo/services/network/publi...
mojo/services/network/public/interfaces/BUILD.gn:24: import_from = mojo_root
Was the removal of this line intentional and necessary? It breaks the ability of
a particular consumer of the mojo SDK from being able to include
network_service.mojom.dart.

[jamesr, 2015-04-02 20:53:07]

On 2015/04/02 20:50:18, tonyg wrote:
>
https://codereview.chromium.org/1059543002/diff/1/mojo/services/network/publi...
> File mojo/services/network/public/interfaces/BUILD.gn (left):
> 
>
https://codereview.chromium.org/1059543002/diff/1/mojo/services/network/publi...
> mojo/services/network/public/interfaces/BUILD.gn:24: import_from = mojo_root
> Was the removal of this line intentional and necessary? It breaks the ability
of
> a particular consumer of the mojo SDK from being able to include
> network_service.mojom.dart.

Oh, that's what it's for?  The change was generated by the roll script and Trung
and I couldn't figure out what was going on.

[tonyg, 2015-04-02 20:58:07]

tonyg@chromium.org changed reviewers:
+ zra@google.com

[tonyg, 2015-04-02 20:59:17]

On 2015/04/02 20:53:07, jamesr wrote:
> On 2015/04/02 20:50:18, tonyg wrote:
> >
>
https://codereview.chromium.org/1059543002/diff/1/mojo/services/network/publi...
> > File mojo/services/network/public/interfaces/BUILD.gn (left):
> > 
> >
>
https://codereview.chromium.org/1059543002/diff/1/mojo/services/network/publi...
> > mojo/services/network/public/interfaces/BUILD.gn:24: import_from = mojo_root
> > Was the removal of this line intentional and necessary? It breaks the
ability
> of
> > a particular consumer of the mojo SDK from being able to include
> > network_service.mojom.dart.
> 
> Oh, that's what it's for?  The change was generated by the roll script and
Trung
> and I couldn't figure out what was going on.

Yeah, zra added it here: https://codereview.chromium.org/1022703005 and I don't
think he or I considered that fact that the patch modified a file which is
rolled in and would be stomped on in the next roll.

IIRC, there was some kind of plan for allowing the build system to find
everything without those lines. But I'm not sure what to do in the meantime,
given that even if we change it back again, it'll probably get stomped on again
soon.

[jamesr, 2015-04-02 21:04:23]

We have the ability to carry patches and ignore changes in things that are
rolled in.  What script updates this file?

[tonyg, 2015-04-02 21:05:57]

On 2015/04/02 21:04:23, jamesr wrote:
> We have the ability to carry patches and ignore changes in things that are
> rolled in.  What script updates this file?

Oh cool. I believe it's mojo/tools/roll/roll_network_service.py

[jamesr, 2015-04-02 21:09:16]

On 2015/04/02 21:05:57, tonyg wrote:
> On 2015/04/02 21:04:23, jamesr wrote:
> > We have the ability to carry patches and ignore changes in things that are
> > rolled in.  What script updates this file?
> 
> Oh cool. I believe it's mojo/tools/roll/roll_network_service.py

OK.  The roll script for the other things pulled from chromium applies patch
files and reverts changes here:

https://github.com/domokit/mojo/blob/master/mojo/tools/roll/update_from_chrom...

I think adding a patchfile and doing something like patch.py would probably work
for this?

[eseidel, 2015-04-02 22:05:27]

eseidel@chromium.org changed reviewers:
+ eseidel@chromium.org

[eseidel, 2015-04-02 22:05:27]

SkyShell broke after this change.  Unclear if this is a SkyShell bug or a
resulting bug in the Java IPC layer:

W/System.err(17943): java.lang.NullPointerException: Attempt to invoke virtual
method 'int java.nio.ByteBuffer.getInt(int)' on a null object reference
W/System.err(17943): 	at
org.chromium.mojo.system.impl.CoreImpl.readMessage(CoreImpl.java:315)
W/System.err(17943): 	at
org.chromium.mojo.system.impl.MessagePipeHandleImpl.readMessage(MessagePipeHandleImpl.java:55)
W/System.err(17943): 	at
org.chromium.mojo.bindings.Connector.readAndDispatchMessage(Connector.java:229)
W/System.err(17943): 	at
org.chromium.mojo.bindings.Connector.readOutstandingMessages(Connector.java:200)
W/System.err(17943): 	at
org.chromium.mojo.bindings.Connector.onAsyncWaiterResult(Connector.java:166)
W/System.err(17943): 	at
org.chromium.mojo.bindings.Connector.access$100(Connector.java:24)
W/System.err(17943): 	at
org.chromium.mojo.bindings.Connector$AsyncWaiterCallback.onResult(Connector.java:147)
W/System.err(17943): 	at
org.chromium.mojo.system.impl.CoreImpl.onAsyncWaitResult(CoreImpl.java:563)
W/System.err(17943): 	at
org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method)
W/System.err(17943): 	at
org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:53)
W/System.err(17943): 	at android.os.Handler.dispatchMessage(Handler.java:102)
W/System.err(17943): 	at android.os.Looper.loop(Looper.java:135)
W/System.err(17943): 	at
android.app.ActivityThread.main(ActivityThread.java:5245)
W/System.err(17943): 	at java.lang.reflect.Method.invoke(Native Method)
W/System.err(17943): 	at java.lang.reflect.Method.invoke(Method.java:372)
W/System.err(17943): 	at
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
W/System.err(17943): 	at
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)
F/chromium(17943): [FATAL:jni_android.cc(295)] Check failed: false. Please
include Java exception stack in crash report
F/libc    (17943): Fatal signal 6 (SIGABRT), code -6 in tid 17943
(omokit.sky.demo)
I/DEBUG   (25951): *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
***
I/DEBUG   (25951): Build fingerprint:
'google/hammerhead/hammerhead:5.1/LMY06B/1666863:userdebug/dev-keys'
I/DEBUG   (25951): Revision: '11'
I/DEBUG   (25951): ABI: 'arm'
I/DEBUG   (25951): pid: 17943, tid: 17943, name: omokit.sky.demo  >>>
org.domokit.sky.demo <<<
I/DEBUG   (25951): signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
I/DEBUG   (25951): Abort message: '[FATAL:jni_android.cc(295)] Check failed:
false. Please include Java exception stack in crash report
I/DEBUG   (25951): '
I/DEBUG   (25951):     r0 00000000  r1 00004617  r2 00000006  r3 00000000
I/DEBUG   (25951):     r4 b6f09e38  r5 00000006  r6 0000000b  r7 0000010c
I/DEBUG   (25951):     r8 be973fcc  r9 00000000  sl be973f88  fp be973f90
I/DEBUG   (25951):     ip 00004617  sp be973ab0  lr b6d873c5  pc b6da9ecc  cpsr
600f0010
I/DEBUG   (25951): 
I/DEBUG   (25951): backtrace:
I/DEBUG   (25951):     #00 pc 00039ecc  /system/lib/libc.so (tgkill+12)
I/DEBUG   (25951):     #01 pc 000173c1  /system/lib/libc.so (pthread_kill+52)
I/DEBUG   (25951):     #02 pc 00017fd3  /system/lib/libc.so (raise+10)
I/DEBUG   (25951):     #03 pc 00014795  /system/lib/libc.so
(__libc_android_abort+36)
I/DEBUG   (25951):     #04 pc 00012f44  /system/lib/libc.so (abort+4)
I/DEBUG   (25951):     #05 pc 001da809 
/data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
I/DEBUG   (25951):     #06 pc 00096489 
/data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
I/DEBUG   (25951):     #07 pc 0008d89d 
/data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
I/DEBUG   (25951):     #08 pc 000a7957 
/data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
I/DEBUG   (25951):     #09 pc 000a8b91 
/data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
I/DEBUG   (25951):     #10 pc 000a8841 
/data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
I/DEBUG   (25951):     #11 pc 001dad2b 
/data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
I/DEBUG   (25951):     #12 pc 00097d45 
/data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
I/DEBUG   (25951):     #13 pc 0009833f 
/data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
I/DEBUG   (25951):     #14 pc 00098abd 
/data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
I/DEBUG   (25951):     #15 pc 000993b7 
/data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
I/DEBUG   (25951):     #16 pc 00041af3 
/data/dalvik-cache/arm/data@app@org.domokit.sky.demo-2@base.apk@classes.dex
E/AudioTrack(  767): did not receive expected priority boost on time
I/ConfigFetchService(10823): fetch service done; releasing wakelock
I/ConfigFetchService(10823): stopping self
I/ConfigService(10795): onDestroy
W/ActivityManager(  767):   Force finishing activity 1
org.domokit.sky.demo/.SkyDemoActivity
I/DEBUG   (25951): 
I/DEBUG   (25951): Tombstone written to: /data/tombstones/tombstone_06
I/BootReceiver(  767): Copying /data/tombstones/tombstone_06 to DropBox
(SYSTEM_TOMBSTONE)
I/WindowState(  767): WIN DEATH: Window{853cd25 u0
org.domokit.sky.demo/org.domokit.sky.demo.SkyDemoActivity}
I/WindowState(  767): WIN DEATH: Window{30d7cab u0 SurfaceView}
I/Zygote  (  201): Process 17943 exited due to signal (6)
W/ActivityManager(  767): Exception thrown during pause
W/ActivityManager(  767): android.os.DeadObjectException
W/ActivityManager(  767): 	at android.os.BinderProxy.transactNative(Native
Method)
W/ActivityManager(  767): 	at android.os.BinderProxy.transact(Binder.java:496)
W/ActivityManager(  767): 	at
android.app.ApplicationThreadProxy.schedulePauseActivity(ApplicationThreadNative.java:704)
W/ActivityManager(  767): 	at
com.android.server.am.ActivityStack.startPausingLocked(ActivityStack.java:825)
W/ActivityManager(  767): 	at
com.android.server.am.ActivityStack.finishActivityLocked(ActivityStack.java:2726)
W/ActivityManager(  767): 	at
com.android.server.am.ActivityStack.finishTopRunningActivityLocked(ActivityStack.java:2583)
W/ActivityManager(  767): 	at
com.android.server.am.ActivityStackSupervisor.finishTopRunningActivityLocked(ActivityStackSupervisor.java:2478)
W/ActivityManager(  767): 	at
com.android.server.am.ActivityManagerService.handleAppCrashLocked(ActivityManagerService.java:11467)
W/ActivityManager(  767): 	at
com.android.server.am.ActivityManagerService.makeAppCrashingLocked(ActivityManagerService.java:11364)
W/ActivityManager(  767): 	at
com.android.server.am.ActivityManagerService.crashApplication(ActivityManagerService.java:12048)
W/ActivityManager(  767): 	at
com.android.server.am.ActivityManagerService.handleApplicationCrashInner(ActivityManagerService.java:11559)
W/ActivityManager(  767): 	at
com.android.server.am.NativeCrashListener$NativeCrashReporter.run(NativeCrashListener.java:86)

[viettrungluu, 2015-04-02 22:15:34]

On 2015/04/02 22:05:27, eseidel wrote:
> SkyShell broke after this change.  Unclear if this is a SkyShell bug or a
> resulting bug in the Java IPC layer:
> 
> W/System.err(17943): java.lang.NullPointerException: Attempt to invoke virtual
> method 'int java.nio.ByteBuffer.getInt(int)' on a null object reference
> W/System.err(17943): 	at
> org.chromium.mojo.system.impl.CoreImpl.readMessage(CoreImpl.java:315)
> W/System.err(17943): 	at
>
org.chromium.mojo.system.impl.MessagePipeHandleImpl.readMessage(MessagePipeHandleImpl.java:55)
> W/System.err(17943): 	at
>
org.chromium.mojo.bindings.Connector.readAndDispatchMessage(Connector.java:229)
> W/System.err(17943): 	at
>
org.chromium.mojo.bindings.Connector.readOutstandingMessages(Connector.java:200)
> W/System.err(17943): 	at
> org.chromium.mojo.bindings.Connector.onAsyncWaiterResult(Connector.java:166)
> W/System.err(17943): 	at
> org.chromium.mojo.bindings.Connector.access$100(Connector.java:24)
> W/System.err(17943): 	at
>
org.chromium.mojo.bindings.Connector$AsyncWaiterCallback.onResult(Connector.java:147)
> W/System.err(17943): 	at
> org.chromium.mojo.system.impl.CoreImpl.onAsyncWaitResult(CoreImpl.java:563)
> W/System.err(17943): 	at
> org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method)
> W/System.err(17943): 	at
>
org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:53)
> W/System.err(17943): 	at android.os.Handler.dispatchMessage(Handler.java:102)
> W/System.err(17943): 	at android.os.Looper.loop(Looper.java:135)
> W/System.err(17943): 	at
> android.app.ActivityThread.main(ActivityThread.java:5245)
> W/System.err(17943): 	at java.lang.reflect.Method.invoke(Native Method)
> W/System.err(17943): 	at java.lang.reflect.Method.invoke(Method.java:372)
> W/System.err(17943): 	at
>
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
> W/System.err(17943): 	at
> com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)
> F/chromium(17943): [FATAL:jni_android.cc(295)] Check failed: false. Please
> include Java exception stack in crash report
> F/libc    (17943): Fatal signal 6 (SIGABRT), code -6 in tid 17943
> (omokit.sky.demo)
> I/DEBUG   (25951): *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
> ***
> I/DEBUG   (25951): Build fingerprint:
> 'google/hammerhead/hammerhead:5.1/LMY06B/1666863:userdebug/dev-keys'
> I/DEBUG   (25951): Revision: '11'
> I/DEBUG   (25951): ABI: 'arm'
> I/DEBUG   (25951): pid: 17943, tid: 17943, name: omokit.sky.demo  >>>
> org.domokit.sky.demo <<<
> I/DEBUG   (25951): signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
> I/DEBUG   (25951): Abort message: '[FATAL:jni_android.cc(295)] Check failed:
> false. Please include Java exception stack in crash report
> I/DEBUG   (25951): '
> I/DEBUG   (25951):     r0 00000000  r1 00004617  r2 00000006  r3 00000000
> I/DEBUG   (25951):     r4 b6f09e38  r5 00000006  r6 0000000b  r7 0000010c
> I/DEBUG   (25951):     r8 be973fcc  r9 00000000  sl be973f88  fp be973f90
> I/DEBUG   (25951):     ip 00004617  sp be973ab0  lr b6d873c5  pc b6da9ecc 
cpsr
> 600f0010
> I/DEBUG   (25951): 
> I/DEBUG   (25951): backtrace:
> I/DEBUG   (25951):     #00 pc 00039ecc  /system/lib/libc.so (tgkill+12)
> I/DEBUG   (25951):     #01 pc 000173c1  /system/lib/libc.so (pthread_kill+52)
> I/DEBUG   (25951):     #02 pc 00017fd3  /system/lib/libc.so (raise+10)
> I/DEBUG   (25951):     #03 pc 00014795  /system/lib/libc.so
> (__libc_android_abort+36)
> I/DEBUG   (25951):     #04 pc 00012f44  /system/lib/libc.so (abort+4)
> I/DEBUG   (25951):     #05 pc 001da809 
> /data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
> I/DEBUG   (25951):     #06 pc 00096489 
> /data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
> I/DEBUG   (25951):     #07 pc 0008d89d 
> /data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
> I/DEBUG   (25951):     #08 pc 000a7957 
> /data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
> I/DEBUG   (25951):     #09 pc 000a8b91 
> /data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
> I/DEBUG   (25951):     #10 pc 000a8841 
> /data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
> I/DEBUG   (25951):     #11 pc 001dad2b 
> /data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
> I/DEBUG   (25951):     #12 pc 00097d45 
> /data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
> I/DEBUG   (25951):     #13 pc 0009833f 
> /data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
> I/DEBUG   (25951):     #14 pc 00098abd 
> /data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
> I/DEBUG   (25951):     #15 pc 000993b7 
> /data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
> I/DEBUG   (25951):     #16 pc 00041af3 
>
mailto:/data/dalvik-cache/arm/data@app@org.domokit.sky.demo-2@base.apk@classes.dex
> E/AudioTrack(  767): did not receive expected priority boost on time
> I/ConfigFetchService(10823): fetch service done; releasing wakelock
> I/ConfigFetchService(10823): stopping self
> I/ConfigService(10795): onDestroy
> W/ActivityManager(  767):   Force finishing activity 1
> org.domokit.sky.demo/.SkyDemoActivity
> I/DEBUG   (25951): 
> I/DEBUG   (25951): Tombstone written to: /data/tombstones/tombstone_06
> I/BootReceiver(  767): Copying /data/tombstones/tombstone_06 to DropBox
> (SYSTEM_TOMBSTONE)
> I/WindowState(  767): WIN DEATH: Window{853cd25 u0
> org.domokit.sky.demo/org.domokit.sky.demo.SkyDemoActivity}
> I/WindowState(  767): WIN DEATH: Window{30d7cab u0 SurfaceView}
> I/Zygote  (  201): Process 17943 exited due to signal (6)
> W/ActivityManager(  767): Exception thrown during pause
> W/ActivityManager(  767): android.os.DeadObjectException
> W/ActivityManager(  767): 	at android.os.BinderProxy.transactNative(Native
> Method)
> W/ActivityManager(  767): 	at android.os.BinderProxy.transact(Binder.java:496)
> W/ActivityManager(  767): 	at
>
android.app.ApplicationThreadProxy.schedulePauseActivity(ApplicationThreadNative.java:704)
> W/ActivityManager(  767): 	at
> com.android.server.am.ActivityStack.startPausingLocked(ActivityStack.java:825)
> W/ActivityManager(  767): 	at
>
com.android.server.am.ActivityStack.finishActivityLocked(ActivityStack.java:2726)
> W/ActivityManager(  767): 	at
>
com.android.server.am.ActivityStack.finishTopRunningActivityLocked(ActivityStack.java:2583)
> W/ActivityManager(  767): 	at
>
com.android.server.am.ActivityStackSupervisor.finishTopRunningActivityLocked(ActivityStackSupervisor.java:2478)
> W/ActivityManager(  767): 	at
>
com.android.server.am.ActivityManagerService.handleAppCrashLocked(ActivityManagerService.java:11467)
> W/ActivityManager(  767): 	at
>
com.android.server.am.ActivityManagerService.makeAppCrashingLocked(ActivityManagerService.java:11364)
> W/ActivityManager(  767): 	at
>
com.android.server.am.ActivityManagerService.crashApplication(ActivityManagerService.java:12048)
> W/ActivityManager(  767): 	at
>
com.android.server.am.ActivityManagerService.handleApplicationCrashInner(ActivityManagerService.java:11559)
> W/ActivityManager(  767): 	at
>
com.android.server.am.NativeCrashListener$NativeCrashReporter.run(NativeCrashListener.java:86)

https://codereview.chromium.org/1058143002 may fix this, perhaps, maybe.