Issue 1058143002: Fix Android for positive MojoResults.

Issue 1058143002: Fix Android for positive MojoResults. (Closed)

Created:
5 years, 8 months ago by viettrungluu

Modified:
5 years, 8 months ago

Reviewers:
jamesr, qsr, eseidel

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix Android for positive MojoResults. R=jamesr@chromium.org

Patch Set 2 : oops #

Total comments: 4

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -9 lines)			Patch
	M	mojo/android/system/core_impl.cc	View		2 chunks	+2 lines, -2 lines	2 comments	Download
	M	mojo/android/system/src/org/chromium/mojo/system/impl/CoreImpl.java	View	1	3 chunks	+3 lines, -7 lines	2 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

eseidel

This does not fix SkyShell.apk quiet yet. I still get: W/System.err(18587): java.lang.NullPointerException: Attempt to invoke ...

5 years, 8 months ago (2015-04-02 22:18:28 UTC) #3

This does not fix SkyShell.apk quiet yet. I still get:

W/System.err(18587): java.lang.NullPointerException: Attempt to invoke virtual
method 'int java.nio.ByteBuffer.getInt(int)' on a null object reference
W/System.err(18587): 	at
org.chromium.mojo.system.impl.CoreImpl.readMessage(CoreImpl.java:315)
W/System.err(18587): 	at
org.chromium.mojo.system.impl.MessagePipeHandleImpl.readMessage(MessagePipeHandleImpl.java:55)
W/System.err(18587): 	at
org.chromium.mojo.bindings.Connector.readAndDispatchMessage(Connector.java:229)
W/System.err(18587): 	at
org.chromium.mojo.bindings.Connector.readOutstandingMessages(Connector.java:200)
W/System.err(18587): 	at
org.chromium.mojo.bindings.Connector.onAsyncWaiterResult(Connector.java:166)
W/System.err(18587): 	at
org.chromium.mojo.bindings.Connector.access$100(Connector.java:24)
W/System.err(18587): 	at
org.chromium.mojo.bindings.Connector$AsyncWaiterCallback.onResult(Connector.java:147)
W/System.err(18587): 	at
org.chromium.mojo.system.impl.CoreImpl.onAsyncWaitResult(CoreImpl.java:563)
W/System.err(18587): 	at
org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method)
W/System.err(18587): 	at
org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:53)
W/System.err(18587): 	at android.os.Handler.dispatchMessage(Handler.java:102)
W/System.err(18587): 	at android.os.Looper.loop(Looper.java:135)
W/System.err(18587): 	at
android.app.ActivityThread.main(ActivityThread.java:5245)
W/System.err(18587): 	at java.lang.reflect.Method.invoke(Native Method)
W/System.err(18587): 	at java.lang.reflect.Method.invoke(Method.java:372)
W/System.err(18587): 	at
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
W/System.err(18587): 	at
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)
F/chromium(18587): [FATAL:jni_android.cc(295)] Check failed: false. Please
include Java exception stack in crash report
F/libc    (18587): Fatal signal 6 (SIGABRT), code -6 in tid 18587
(omokit.sky.demo)
I/DEBUG   (25951): *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
***
I/DEBUG   (25951): Build fingerprint:
'google/hammerhead/hammerhead:5.1/LMY06B/1666863:userdebug/dev-keys'
I/DEBUG   (25951): Revision: '11'
I/DEBUG   (25951): ABI: 'arm'
I/DEBUG   (25951): pid: 18587, tid: 18587, name: omokit.sky.demo  >>>
org.domokit.sky.demo <<<
I/DEBUG   (25951): signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
I/DEBUG   (25951): Abort message: '[FATAL:jni_android.cc(295)] Check failed:
false. Please include Java exception stack in crash report
I/DEBUG   (25951): '
I/DEBUG   (25951):     r0 00000000  r1 0000489b  r2 00000006  r3 00000000
I/DEBUG   (25951):     r4 b6f09e38  r5 00000006  r6 0000000b  r7 0000010c
I/DEBUG   (25951):     r8 be973fcc  r9 00000000  sl be973f88  fp be973f90
I/DEBUG   (25951):     ip 0000489b  sp be973ab0  lr b6d873c5  pc b6da9ecc  cpsr
600f0010
I/DEBUG   (25951): 
I/DEBUG   (25951): backtrace:
I/DEBUG   (25951):     #00 pc 00039ecc  /system/lib/libc.so (tgkill+12)
I/DEBUG   (25951):     #01 pc 000173c1  /system/lib/libc.so (pthread_kill+52)
I/DEBUG   (25951):     #02 pc 00017fd3  /system/lib/libc.so (raise+10)
I/DEBUG   (25951):     #03 pc 00014795  /system/lib/libc.so
(__libc_android_abort+36)
I/DEBUG   (25951):     #04 pc 00012f44  /system/lib/libc.so (abort+4)
I/DEBUG   (25951):     #05 pc 001da829 
/data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
I/DEBUG   (25951):     #06 pc 00096489 
/data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
I/DEBUG   (25951):     #07 pc 0008d89d 
/data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
I/DEBUG   (25951):     #08 pc 000a7957 
/data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
I/DEBUG   (25951):     #09 pc 000a8b8d 
/data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
I/DEBUG   (25951):     #10 pc 000a883d 
/data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
I/DEBUG   (25951):     #11 pc 001dad4b 
/data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
I/DEBUG   (25951):     #12 pc 00097d45 
/data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
I/DEBUG   (25951):     #13 pc 0009833f 
/data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
I/DEBUG   (25951):     #14 pc 00098abd 
/data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
I/DEBUG   (25951):     #15 pc 000993b7 
/data/app/org.domokit.sky.demo-2/lib/arm/libsky_shell.so
I/DEBUG   (25951):     #16 pc 00041af3 
/data/dalvik-cache/arm/data@app@org.domokit.sky.demo-2@base.apk@classes.dex
E/AudioTrack(  767): did not receive expected priority boost on time
W/ActivityManager(  767):   Force finishing activity 1
org.domokit.sky.demo/.SkyDemoActivity
I/DEBUG   (25951): 
I/DEBUG   (25951): Tombstone written to: /data/tombstones/tombstone_08
I/BootReceiver(  767): Copying /data/tombstones/tombstone_08 to DropBox
(SYSTEM_TOMBSTONE)
I/WindowState(  767): WIN DEATH: Window{136ba8f4 u0
org.domokit.sky.demo/org.domokit.sky.demo.SkyDemoActivity}
I/Zygote  (  201): Process 18587 exited due to signal (6)
W/ActivityManager(  767): Exception thrown during pause
W/ActivityManager(  767): android.os.DeadObjectException
W/ActivityManager(  767): 	at android.os.BinderProxy.transactNative(Native
Method)
W/ActivityManager(  767): 	at android.os.BinderProxy.transact(Binder.java:496)
W/ActivityManager(  767): 	at
android.app.ApplicationThreadProxy.schedulePauseActivity(ApplicationThreadNative.java:704)
W/ActivityManager(  767): 	at
com.android.server.am.ActivityStack.startPausingLocked(ActivityStack.java:825)
W/ActivityManager(  767): 	at
com.android.server.am.ActivityStack.finishActivityLocked(ActivityStack.java:2726)
W/ActivityManager(  767): 	at
com.android.server.am.ActivityStack.finishTopRunningActivityLocked(ActivityStack.java:2583)
W/ActivityManager(  767): 	at
com.android.server.am.ActivityStackSupervisor.finishTopRunningActivityLocked(ActivityStackSupervisor.java:2478)
W/ActivityManager(  767): 	at
com.android.server.am.ActivityManagerService.handleAppCrashLocked(ActivityManagerService.java:11467)
W/ActivityManager(  767): 	at
com.android.server.am.ActivityManagerService.makeAppCrashingLocked(ActivityManagerService.java:11364)
W/ActivityManager(  767): 	at
com.android.server.am.ActivityManagerService.crashApplication(ActivityManagerService.java:12048)
W/ActivityManager(  767): 	at
com.android.server.am.ActivityManagerService.handleApplicationCrashInner(ActivityManagerService.java:11559)
W/ActivityManager(  767): 	at
com.android.server.am.NativeCrashListener$NativeCrashReporter.run(NativeCrashListener.java:86)
E/lowmemorykiller(  171): Error opening /proc/18587/oom_score_adj; errno=2
I/ActivityManager(  767): Process org.domokit.sky.demo (pid 18587) has died

eseidel

I'm testing using this command: gclient sync && ninja -C out/android_Release -j 1024 && adb ...

5 years, 8 months ago (2015-04-02 22:22:26 UTC) #4

viettrungluu

https://codereview.chromium.org/1058143002/diff/20001/mojo/android/system/core_impl.cc File mojo/android/system/core_impl.cc (right): https://codereview.chromium.org/1058143002/diff/20001/mojo/android/system/core_impl.cc#newcode244 mojo/android/system/core_impl.cc:244: return buffer_size; This is very wrong. https://codereview.chromium.org/1058143002/diff/20001/mojo/android/system/core_impl.cc#newcode287 mojo/android/system/core_impl.cc:287: return ...

5 years, 8 months ago (2015-04-02 23:02:42 UTC) #5

viettrungluu

5 years, 8 months ago (2015-04-02 23:13:57 UTC) #7

Our Java Mojo system bindings are too messed up[*] for me to fix right now (and
I'm out tomorrow), so I'm going to revert my change.

E.g., ReadData()/WriteData() overload their return value to return the amount
read/write.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages