Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 1059433003: MIPS: Remove unused J(Label *). (Closed)

Created:
5 years, 8 months ago by paul.l...
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Remove unused J(Label *). Remove unused macro-asm instruction and associated address patching. On mips64, remove unused JumpLabelToJumpRegister(). On mips, rename it appropriately (it's still used there for JR->J optimizations). BUG= Committed: https://crrev.com/0f0ce4a9c63054d41fe0764e0591696b556ceaa5 Cr-Commit-Position: refs/heads/master@{#27593}

Patch Set 1 #

Patch Set 2 : remove one more block of unneeded patching. #

Patch Set 3 : fix a nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -152 lines) Patch
M src/mips/assembler-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/assembler-mips.cc View 6 chunks +6 lines, -38 lines 0 comments Download
M src/mips/assembler-mips-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/mips64/assembler-mips64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 1 2 7 chunks +7 lines, -72 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
paul.l...
PTAL.
5 years, 8 months ago (2015-04-02 17:06:50 UTC) #2
balazs.kilvady
LGTM.
5 years, 8 months ago (2015-04-02 17:31:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059433003/40001
5 years, 8 months ago (2015-04-02 17:36:55 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-02 18:45:10 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-02 18:45:19 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0f0ce4a9c63054d41fe0764e0591696b556ceaa5
Cr-Commit-Position: refs/heads/master@{#27593}

Powered by Google App Engine
This is Rietveld 408576698