Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: components/autofill/core/browser/autofill_external_delegate.h

Issue 1059393002: Remove --respect-autocomplete-off-autofill flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix last 3 tests Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_external_delegate.h
diff --git a/components/autofill/core/browser/autofill_external_delegate.h b/components/autofill/core/browser/autofill_external_delegate.h
index 10a358e70f37f668984453151b7498b10dc125ec..8e8c32091474e370faeb121e2f5b6153f12b5efa 100644
--- a/components/autofill/core/browser/autofill_external_delegate.h
+++ b/components/autofill/core/browser/autofill_external_delegate.h
@@ -47,16 +47,13 @@ class AutofillExternalDelegate : public AutofillPopupDelegate {
// Records and associates a query_id with web form data. Called
// when the renderer posts an Autofill query to the browser. |bounds|
- // is window relative. |display_warning_if_disabled| tells us if we should
- // display warnings (such as autofill is disabled, but had suggestions).
- // We might not want to display the warning if a website has disabled
- // Autocomplete because they have their own popup, and showing our popup
- // on to of theirs would be a poor user experience.
+ // is window relative. We might not want to display the warning if a website
+ // has disabled Autocomplete because they have their own popup, and showing
+ // our popup on to of theirs would be a poor user experience.
virtual void OnQuery(int query_id,
const FormData& form,
const FormFieldData& field,
- const gfx::RectF& element_bounds,
- bool display_warning_if_disabled);
+ const gfx::RectF& element_bounds);
// Records query results and correctly formats them before sending them off
// to be displayed. Called when an Autofill query result is available.
@@ -132,9 +129,6 @@ class AutofillExternalDelegate : public AutofillPopupDelegate {
// The bounds of the form field that user is interacting with.
gfx::RectF element_bounds_;
- // Should we display a warning if Autofill is disabled?
- bool display_warning_if_disabled_;
-
// Does the popup include any Autofill profile or credit card suggestions?
bool has_suggestion_;

Powered by Google App Engine
This is Rietveld 408576698