Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: ui/views/widget/widget.cc

Issue 1059383003: Make sure observers are not nullptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/display_change_notifier_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/widget.cc
diff --git a/ui/views/widget/widget.cc b/ui/views/widget/widget.cc
index 15b810a90c1804c1f9adb1250b78e4f1d836ba57..8b391b63e17ad06597009ecd9fc64c65a6890b3a 100644
--- a/ui/views/widget/widget.cc
+++ b/ui/views/widget/widget.cc
@@ -389,6 +389,8 @@ gfx::NativeWindow Widget::GetNativeWindow() const {
}
void Widget::AddObserver(WidgetObserver* observer) {
+ // TODO(oshima): Remove this CHECK once crbug.com/471649 is resolved.
sadrul 2015/04/08 19:12:33 I actually like this check. Maybe just always keep
oshima 2015/04/08 19:17:10 Sure. I just updated the comment to give more cont
danakj 2015/04/08 20:03:45 Why CHECK instead of DCHECK? It adds code/strings
+ CHECK(observer);
observers_.AddObserver(observer);
}
« no previous file with comments | « ui/gfx/display_change_notifier_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698