Make sure observers are not nullptr

ui/views/widget/widget.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/widget.h"
 
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/trace_event/trace_event.h"
@@ skipping 371 matching lines @@
 
 gfx::NativeView Widget::GetNativeView() const {
   return native_widget_->GetNativeView();
 }
 
 gfx::NativeWindow Widget::GetNativeWindow() const {
   return native_widget_->GetNativeWindow();
 }
 
 void Widget::AddObserver(WidgetObserver* observer) {
+  // TODO(oshima): Remove this CHECK once crbug.com/471649 is resolved.

[sadrul, 2015/04/08 19:12:33]

I actually like this check. Maybe just always keep it and remove the TODO?

[oshima, 2015/04/08 19:17:10]

Sure. I just updated the comment to give more context.

[danakj, 2015/04/08 20:03:45]

Why CHECK instead of DCHECK? It adds code/strings to the binary we ship.

+  CHECK(observer);
   observers_.AddObserver(observer);
 }
 
 void Widget::RemoveObserver(WidgetObserver* observer) {
   observers_.RemoveObserver(observer);
 }
 
 bool Widget::HasObserver(const WidgetObserver* observer) const {
   return observers_.HasObserver(observer);
 }
@@ skipping 1134 matching lines @@
 
 ////////////////////////////////////////////////////////////////////////////////
 // internal::NativeWidgetPrivate, NativeWidget implementation:
 
 internal::NativeWidgetPrivate* NativeWidgetPrivate::AsNativeWidgetPrivate() {
   return this;
 }
 
 }  // namespace internal
 }  // namespace views