net/data/ssl/scripts/ee.cnf - Issue 1059303002: Don't process HSTS/HPKP headers when host is an IP address

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/data/ssl/scripts/ee.cnf

Issue 1059303002: Don't process HSTS/HPKP headers when host is an IP address (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tweak |try| to retain exit code Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/data/ssl/certificates/localhost_cert.pem ('k') | net/data/ssl/scripts/generate-cross-signed-certs.sh » ('j') | net/data/ssl/scripts/generate-cross-signed-certs.sh » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/data/ssl/scripts/ee.cnf

diff --git a/net/data/ssl/scripts/ee.cnf b/net/data/ssl/scripts/ee.cnf

index fa2a89b6ebf46fbc56b5e3a6fd0297b1a1df10e8..1be5e67134eb83303781d8b7c61d28543e5d11ac 100644

--- a/net/data/ssl/scripts/ee.cnf

+++ b/net/data/ssl/scripts/ee.cnf

@@ -25,12 +25,21 @@ CN = Duplicate

O = Bar

CN = Duplicate

+[req_localhost_cn]

+C = US

+ST = California

+L = Mountain View

+O = Test CA

+CN = localhost

[req_punycode_dn]

CN = xn--wgv71a119e.com

[req_extensions]

subjectAltName = IP:127.0.0.1

+[req_extensions_none]

Ryan Sleevi 2015/04/04 00:35:24 Nah, we need a san of localhost. Recall that I'm

estark 2015/04/06 16:41:13 Done.

[req_punycode]

basicConstraints = critical, CA:true

subjectAltName = @punycode_san