net/data/ssl/scripts/ee.cnf - Issue 1059303002: Don't process HSTS/HPKP headers when host is an IP address

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/data/ssl/scripts/ee.cnf

Issue 1059303002: Don't process HSTS/HPKP headers when host is an IP address (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tweak |try| to retain exit code Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « net/data/ssl/certificates/localhost_cert.pem ('k') | net/data/ssl/scripts/generate-cross-signed-certs.sh » ('j') | net/data/ssl/scripts/generate-cross-signed-certs.sh » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 SUBJECT_NAME = req_dn	1 SUBJECT_NAME = req_dn

2 KEY_SIZE = 2048	2 KEY_SIZE = 2048

3	3

4 [req]	4 [req]

5 default_bits = ${ENV::KEY_SIZE}	5 default_bits = ${ENV::KEY_SIZE}

6 default_md = sha256	6 default_md = sha256

7 string_mask = utf8only	7 string_mask = utf8only

8 prompt = no	8 prompt = no

9 encrypt_key = no	9 encrypt_key = no

10 distinguished_name = ${ENV::SUBJECT_NAME}	10 distinguished_name = ${ENV::SUBJECT_NAME}

11 req_extensions = req_extensions	11 req_extensions = req_extensions

12	12

13 [req_dn]	13 [req_dn]

14 C = US	14 C = US

15 ST = California	15 ST = California

16 L = Mountain View	16 L = Mountain View

17 O = Test CA	17 O = Test CA

18 CN = 127.0.0.1	18 CN = 127.0.0.1

19	19

20 [req_duplicate_cn_1]	20 [req_duplicate_cn_1]

21 O = Foo	21 O = Foo

22 CN = Duplicate	22 CN = Duplicate

23	23

24 [req_duplicate_cn_2]	24 [req_duplicate_cn_2]

25 O = Bar	25 O = Bar

26 CN = Duplicate	26 CN = Duplicate

27	27

	28 [req_localhost_cn]

	29 C = US

	30 ST = California

	31 L = Mountain View

	32 O = Test CA

	33 CN = localhost

	34

28 [req_punycode_dn]	35 [req_punycode_dn]

29 CN = xn--wgv71a119e.com	36 CN = xn--wgv71a119e.com

30	37

31 [req_extensions]	38 [req_extensions]

32 subjectAltName = IP:127.0.0.1	39 subjectAltName = IP:127.0.0.1

33	40

	41 [req_extensions_none]
	Ryan Sleevi 2015/04/04 00:35:24 Nah, we need a san of localhost. Recall that I'm Nah, we need a san of localhost. Recall that I'm trying to kill CN ( crbug.com/308330 , should make a move soon), so let's make sure our cert matches our desired goal [req_localhost_san] subjectAltName = DNS:localhost estark 2015/04/06 16:41:13 Done. Show quoted text On 2015/04/04 00:35:24, Ryan Sleevi wrote: > Nah, we need a san of localhost. > > Recall that I'm trying to kill CN ( crbug.com/308330 , should make a move soon), > so let's make sure our cert matches our desired goal > > [req_localhost_san] > subjectAltName = DNS:localhost Done.
	42

34 [req_punycode]	43 [req_punycode]

35 basicConstraints = critical, CA:true	44 basicConstraints = critical, CA:true

36 subjectAltName = @punycode_san	45 subjectAltName = @punycode_san

37	46

38 [req_san_sanity]	47 [req_san_sanity]

39 basicConstraints = critical, CA:true	48 basicConstraints = critical, CA:true

40 subjectAltName = @san_sanity	49 subjectAltName = @san_sanity

41	50

42 [san_sanity]	51 [san_sanity]

43 IP.1 = 127.0.0.2	52 IP.1 = 127.0.0.2

(...skipping 11 matching lines...) Expand all Loading...
55	64

56 [spdy_pooling]	65 [spdy_pooling]

57 DNS.1 = www.example.org	66 DNS.1 = www.example.org

58 DNS.2 = mail.example.org	67 DNS.2 = mail.example.org

59 DNS.3 = mail.example.com	68 DNS.3 = mail.example.com

60	69

61 [punycode_san]	70 [punycode_san]

62 DNS.1 = xn--wgv71a119e.com	71 DNS.1 = xn--wgv71a119e.com

63 DNS.2 = *.xn--wgv71a119e.com	72 DNS.2 = *.xn--wgv71a119e.com

64 DNS.3 = blahblahblahblah.com	73 DNS.3 = blahblahblahblah.com

OLD	NEW