Expose GetBaseline() method on RenderText.

Expose GetBaseline() method on RenderText.

This is needed for use by autocomplete_result_view.cc for
text alignment and my rewrite of print_web_view_helper.cc's
use of RenderText.

BUG=128027, 105550
TEST=New unit test.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143705

[Alexei Svitkine (slow), 2012-06-21 20:02:19]

.

[Alexei Svitkine (slow), 2012-06-22 15:57:20]

(The initial publish mail didn't go out due to a codereview bug. :\)

On Fri, Jun 22, 2012 at 11:28 AM, <asvitkine@chromium.org> wrote:

>
http://codereview.chromium.**org/10591003/<http://codereview.chromium.org/105...
>

[msw, 2012-06-22 17:35:37]

LGTM with nits.

http://codereview.chromium.org/10591003/diff/21001/ui/gfx/render_text.h
File ui/gfx/render_text.h (right):

http://codereview.chromium.org/10591003/diff/21001/ui/gfx/render_text.h#newco...
ui/gfx/render_text.h:256: // offset from the top of |display_rect| to the text
baseline.
nit: specify pixel units?

http://codereview.chromium.org/10591003/diff/21001/ui/gfx/render_text_linux.cc
File ui/gfx/render_text_linux.cc (right):

http://codereview.chromium.org/10591003/diff/21001/ui/gfx/render_text_linux.c...
ui/gfx/render_text_linux.cc:105: return
PANGO_PIXELS(pango_layout_get_baseline(layout_));
Does this need that DIP/Hi-DPI function instead?

[Alexei Svitkine (slow), 2012-06-22 17:54:07]

http://codereview.chromium.org/10591003/diff/21001/ui/gfx/render_text.h
File ui/gfx/render_text.h (right):

http://codereview.chromium.org/10591003/diff/21001/ui/gfx/render_text.h#newco...
ui/gfx/render_text.h:256: // offset from the top of |display_rect| to the text
baseline.
On 2012/06/22 17:35:38, msw wrote:
> nit: specify pixel units?

Done.

http://codereview.chromium.org/10591003/diff/21001/ui/gfx/render_text_linux.cc
File ui/gfx/render_text_linux.cc (right):

http://codereview.chromium.org/10591003/diff/21001/ui/gfx/render_text_linux.c...
ui/gfx/render_text_linux.cc:105: return
PANGO_PIXELS(pango_layout_get_baseline(layout_));
On 2012/06/22 17:35:38, msw wrote:
> Does this need that DIP/Hi-DPI function instead?

It doesn't. There's no plan to do subpixel positioning on the y axis.

[commit-bot: I haz the power, 2012-06-22 17:55:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10591003/13002

[commit-bot: I haz the power, 2012-06-22 20:53:24]

Change committed as 143705