Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1059063002: Add a Win Clang deterministic builder. (Closed)

Created:
5 years, 8 months ago by Sébastien Marchand
Modified:
5 years, 8 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Add a Win Clang deterministic builder. BUG=330260 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294949

Patch Set 1 : #

Patch Set 2 : Remove the old Windows builder. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -18 lines) Patch
M masters/master.chromium.swarm/master.cfg View 3 chunks +3 lines, -0 lines 0 comments Download
M masters/master.chromium.swarm/slaves.cfg View 1 2 chunks +1 line, -9 lines 0 comments Download
M scripts/slave/recipes/swarming/deterministic_build.py View 1 chunk +5 lines, -0 lines 1 comment Download
A + scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Windows_Clang_deterministic_build.json View 5 chunks +5 lines, -9 lines 2 comments Download

Messages

Total messages: 9 (3 generated)
Sébastien Marchand
PTAL.
5 years, 8 months ago (2015-04-02 21:41:52 UTC) #3
M-A Ruel
I don't see where clang is enabled
5 years, 8 months ago (2015-04-03 00:13:46 UTC) #4
Sébastien Marchand
https://codereview.chromium.org/1059063002/diff/40001/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Windows_Clang_deterministic_build.json File scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Windows_Clang_deterministic_build.json (right): https://codereview.chromium.org/1059063002/diff/40001/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Windows_Clang_deterministic_build.json#newcode80 scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Windows_Clang_deterministic_build.json:80: "GYP_DEFINES": "clang=1 component=static_library dont_embed_build_metadata=1 fastbuild=1 target_arch=ia32 test_isolation_mode=prepare" proof #1 ...
5 years, 8 months ago (2015-04-03 00:15:00 UTC) #5
M-A Ruel
lgtm
5 years, 8 months ago (2015-04-07 17:15:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059063002/40001
5 years, 8 months ago (2015-04-22 18:48:05 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 18:52:18 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294949

Powered by Google App Engine
This is Rietveld 408576698