chromeos/network/onc/onc_utils.cc - Issue 1059033002: Implement networkingPrivate.getDeviceStates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_utils.cc

Issue 1059033002: Implement networkingPrivate.getDeviceStates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/onc/onc_utils.cc

diff --git a/chromeos/network/onc/onc_utils.cc b/chromeos/network/onc/onc_utils.cc

index af0171c4dfa87519a1f0736ffdb14231233daf9f..8749d5a5807e82d5a2a01560006ad1a9f1c47f37 100644

--- a/chromeos/network/onc/onc_utils.cc

+++ b/chromeos/network/onc/onc_utils.cc

@@ -713,7 +713,7 @@ NetworkTypePattern NetworkTypePatternFromOncType(const std::string& type) {

return NetworkTypePattern::Wimax();

if (type == ::onc::network_type::kWireless)

return NetworkTypePattern::Wireless();

- NOTREACHED();

+ NOTREACHED() << "Unrecognized ONC type: " << type;

return NetworkTypePattern::Default();

}