Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: extensions/browser/api/networking_private/networking_private_api.cc

Issue 1059033002: Implement networkingPrivate.getDeviceStates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/networking_private/networking_private_api.cc
diff --git a/extensions/browser/api/networking_private/networking_private_api.cc b/extensions/browser/api/networking_private/networking_private_api.cc
index 92270e905f94cd65367e26bb4c6afa04c6f2a1e1..cefa4082abc979beab4edf83b29ca95662376763 100644
--- a/extensions/browser/api/networking_private/networking_private_api.cc
+++ b/extensions/browser/api/networking_private/networking_private_api.cc
@@ -345,6 +345,31 @@ bool NetworkingPrivateGetEnabledNetworkTypesFunction::RunSync() {
}
////////////////////////////////////////////////////////////////////////////////
+// NetworkingPrivateGetDeviceStatesFunction
+
+NetworkingPrivateGetDeviceStatesFunction::
+ ~NetworkingPrivateGetDeviceStatesFunction() {
+}
+
+bool NetworkingPrivateGetDeviceStatesFunction::RunSync() {
+ scoped_ptr<NetworkingPrivateDelegate::DeviceStateList> device_states(
+ GetDelegate(browser_context())->GetDeviceStateList());
+ LOG(ERROR) << "Get device states.";
pneubeck (no reviews) 2015/04/09 09:41:22 debug left over
stevenjb 2015/04/09 16:20:25 Done.
+ if (!device_states) {
+ LOG(ERROR) << "No device states.";
pneubeck (no reviews) 2015/04/09 09:41:22 probably a warning?
stevenjb 2015/04/09 16:20:25 Done.
+ error_ = networking_private::kErrorNotSupported;
+ return false;
+ }
+
+ scoped_ptr<base::ListValue> device_state_list(new base::ListValue);
+ for (const private_api::DeviceStateProperties* properties : *device_states)
+ device_state_list->Append(properties->ToValue().release());
+ LOG(ERROR) << "Device states: " << device_state_list->GetSize();
pneubeck (no reviews) 2015/04/09 09:41:22 debug left over
stevenjb 2015/04/09 16:20:25 Done.
+ SetResult(device_state_list.release());
+ return true;
+}
+
+////////////////////////////////////////////////////////////////////////////////
// NetworkingPrivateEnableNetworkTypeFunction
NetworkingPrivateEnableNetworkTypeFunction::

Powered by Google App Engine
This is Rietveld 408576698