chromeos/dbus/fake_shill_device_client.cc - Issue 1059033002: Implement networkingPrivate.getDeviceStates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/fake_shill_device_client.cc

Issue 1059033002: Implement networkingPrivate.getDeviceStates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/fake_shill_device_client.cc

diff --git a/chromeos/dbus/fake_shill_device_client.cc b/chromeos/dbus/fake_shill_device_client.cc

index a856bb297dd0f921d3a3847d8ff502dcece94e91..6fe675cfd3b310bac3283adb869dcd908b2df46a 100644

--- a/chromeos/dbus/fake_shill_device_client.cc

+++ b/chromeos/dbus/fake_shill_device_client.cc

@@ -402,9 +402,9 @@ void FakeShillDeviceClient::SetDeviceProperty(const std::string& device_path,

const base::Value& value) {

VLOG(1) << "SetDeviceProperty: " << device_path

<< ": " << name << " = " << value;

- SetProperty(dbus::ObjectPath(device_path), name, value,

- base::Bind(&base::DoNothing),

- base::Bind(&ErrorFunction, device_path));

+ SetPropertyInternal(dbus::ObjectPath(device_path), name, value,

+ base::Bind(&base::DoNothing),

+ base::Bind(&ErrorFunction, device_path));

}

std::string FakeShillDeviceClient::GetDevicePathForType(